Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/nxPublic

fix(core): handle nx config in package.json in move generator#30270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

When the Nx configuration is inpackage.json#nx and not inproject.json, the move generator creates aproject.json file in the new destination.

Expected Behavior

When the Nx configuration is inpackage.json#nx and not inproject.json, the move generator should not create aproject.json file in the new destination and should update thenx entry in thepackage.json file.

Related Issue(s)

Fixes #

@leosvelperezleosvelperez self-assigned thisMar 5, 2025
@leosvelperezleosvelperez requested a review froma team as acode ownerMarch 5, 2025 12:02
@vercelVercel
Copy link

vercelbot commentedMar 5, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

1 Skipped Deployment
NameStatusPreviewUpdated (UTC)
nx-dev⬜️ Ignored (Inspect)Visit PreviewMar 5, 2025 0:02am

@nx-cloudNx Cloud
Copy link
Contributor

nx-cloudbot commentedMar 5, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commite21db83.

CommandStatusDurationResult
nx affected --targets=lint,test,build,e2e,e2e-c...✅ Succeeded7m 11sView ↗
nx run-many -t check-imports check-commit check...✅ Succeeded16sView ↗
nx-cloud record -- nx-cloud conformance:check✅ Succeeded2sView ↗
nx-cloud record -- nx format:check --base=e8aca...✅ Succeeded2sView ↗
nx-cloud record -- nx sync:check✅ Succeeded1sView ↗
nx documentation✅ Succeeded56sView ↗

☁️Nx Cloud last updated this comment at2025-03-05 14:01:09 UTC

@leosvelperezleosvelperezenabled auto-merge (squash)March 5, 2025 13:33
@leosvelperezleosvelperez merged commite4f7e56 intomasterMar 5, 2025
12 checks passed
@leosvelperezleosvelperez deleted the workspace/move-handle-package.json-nx-config branchMarch 5, 2025 14:01
@github-actionsGitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

@FrozenPandazFrozenPandazAwaiting requested review from FrozenPandazFrozenPandaz is a code owner automatically assigned from nrwl/nx-core-reviewers

Assignees

@leosvelperezleosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@leosvelperez@JamesHenry
[8]ページ先頭
©2009-2025 Movatter.jp