Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/nxPublic

fix(nx-dev): remove OTel-based tracing for now to remove local dev erros#30096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaysoo merged 1 commit intomasterfromdocs/fix-serve
Feb 18, 2025

Conversation

jaysoo
Copy link
Member

Locally, when runningnx serve-docs nx-dev, you'll see errors coming from/blog URLs due to instrumentation problems. This is caused by the@grafana/faro-web-tracing packages as soon as it is imported in an app router environment.

We don't need it for now, so we can just remove it. It means that we will be missing tracing on HTTP requests like XHRs, but we still get performance metrics and error reporting.

Current Behavior

See errors in logs during development

Expected Behavior

No errors in logs

Related Issue(s)

Fixes #

@jaysoojaysoo requested a review froma team as acode ownerFebruary 18, 2025 17:41
@vercelVercel
Copy link

vercelbot commentedFeb 18, 2025•
edited
Loading

The latest updates on your projects. Learn more aboutVercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nx-dev✅ Ready (Inspect)Visit PreviewFeb 18, 2025 5:48pm

@nx-cloudNx Cloud
Copy link
Contributor

nx-cloudbot commentedFeb 18, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit11b5df3.

CommandStatusDurationResult
nx affected --targets=lint,test,build,e2e,e2e-c...✅ Succeeded6m 51sView ↗
nx run-many -t check-imports check-commit check...✅ Succeeded15sView ↗
nx-cloud record -- nx-cloud conformance:check✅ Succeeded2sView ↗
nx-cloud record -- nx format:check --base= --he...✅ Succeeded7sView ↗
nx-cloud record -- nx sync:check✅ Succeeded6sView ↗
nx documentation✅ Succeeded<1sView ↗

☁️Nx Cloud last updated this comment at2025-02-18 17:52:06 UTC

@jaysoojaysoo merged commit51a0bae intomasterFeb 18, 2025
12 checks passed
@jaysoojaysoo deleted the docs/fix-serve branchFebruary 18, 2025 19:06
jaysoo added a commit that referenced this pull requestFeb 18, 2025
…ros (#30096)Locally, when running `nx serve-docs nx-dev`, you'll see errors comingfrom `/blog` URLs due to instrumentation problems. This is caused by the`@grafana/faro-web-tracing` packages as soon as it is imported in an approuter environment.We don't need it for now, so we can just remove it. It means that wewill be missing tracing on HTTP requests like XHRs, but we still getperformance metrics and error reporting.## Current BehaviorSee errors in logs during development## Expected BehaviorNo errors in logs## Related Issue(s)<!-- Please link the issue being fixed so it gets closed when this ismerged. -->Fixes #
@github-actionsGitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@isaacplmannisaacplmannisaacplmann approved these changes

@leosvelperezleosvelperezAwaiting requested review from leosvelperezleosvelperez is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaysoo@isaacplmann
[8]ページ先頭
©2009-2025 Movatter.jp