Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
build: add loader path to rpath for cctest#23168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Building on Mac OS/X as follows:```./configure --sharedmake -j4 test```Results in:```dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not foundmake: *** [cctest] Abort trap: 6```This change adds the loader path to the runtime path for the `cctest` executable.
nodejs-github-bot commentedSep 29, 2018
rubys commentedSep 29, 2018
rubys commentedSep 29, 2018
|
addaleax commentedSep 30, 2018
/cc @nodejs/platform-macos |
rubys commentedSep 30, 2018
rubys commentedSep 30, 2018
Restart node test commit:https://ci.nodejs.org/job/node-test-commit/21891/ |
rubys commentedOct 1, 2018
Sigh* Each run has a different set of transient errors. New CI:https://ci.nodejs.org/job/node-test-pull-request/17549/ |
mcollina commentedOct 1, 2018
rubys commentedOct 1, 2018
mhdawson commentedOct 1, 2018
@yhwang can you take a look? |
rubys commentedOct 1, 2018
rubys commentedOct 1, 2018
cc @nodejs/build I'm looking for advice here. I'm adding an option that only applies to shared library builds on Mac OS/X. None of the CI tests are for shared library builds. Despite this, every time I run, I see an intermittent failure (e.g. timeout) on either Linux or Windows. |
refack commentedOct 1, 2018
Am I wrong, buthttps://ci.nodejs.org/job/node-test-pull-request/17564/ seems to be green. |
danbev commentedOct 4, 2018
Landed in6696354. |
Building on Mac OS/X as follows:```./configure --sharedmake -j4 test```Results in:```dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not foundmake: *** [cctest] Abort trap: 6```This change adds the loader path to the runtime path for the `cctest` executable.PR-URL:#23168Reviewed-By: Richard Lau <riclau@uk.ibm.com>Reviewed-By: Refael Ackermann <refack@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
Building on Mac OS/X as follows:```./configure --sharedmake -j4 test```Results in:```dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not foundmake: *** [cctest] Abort trap: 6```This change adds the loader path to the runtime path for the `cctest` executable.PR-URL:#23168Reviewed-By: Richard Lau <riclau@uk.ibm.com>Reviewed-By: Refael Ackermann <refack@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
Building on Mac OS/X as follows:```./configure --sharedmake -j4 test```Results in:```dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not foundmake: *** [cctest] Abort trap: 6```This change adds the loader path to the runtime path for the `cctest` executable.PR-URL:#23168Reviewed-By: Richard Lau <riclau@uk.ibm.com>Reviewed-By: Refael Ackermann <refack@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
Building on Mac OS/X as follows:```./configure --sharedmake -j4 test```Results in:```dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not foundmake: *** [cctest] Abort trap: 6```This change adds the loader path to the runtime path for the `cctest` executable.PR-URL:nodejs#23168Reviewed-By: Richard Lau <riclau@uk.ibm.com>Reviewed-By: Refael Ackermann <refack@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
Building on Mac OS/X as follows:```./configure --sharedmake -j4 test```Results in:```dyld: Library not loaded: @rpath/libnode.67.dylib Referenced from: /Users/rubys/git/node-shared/out/Release/cctest Reason: image not foundmake: *** [cctest] Abort trap: 6```This change adds the loader path to the runtime path for the `cctest` executable.Backport-PR-URL:#25681PR-URL:#23168Reviewed-By: Richard Lau <riclau@uk.ibm.com>Reviewed-By: Refael Ackermann <refack@gmail.com>Reviewed-By: James M Snell <jasnell@gmail.com>
Building on Mac OS/X as follows:
Results in:
This change adds the loader path to the runtime path for the
cctestexecutable.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes