Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(framework-info): add missing types in package.json#4873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kodiakhq merged 2 commits intonetlify:mainfromSevenOutman:fix/framework-info-dts
Feb 27, 2023

Conversation

SevenOutman
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes#4872

I'm using@netlify/framework-info in a TypeScript project and the compiler complains "Cannot find module or declaration".
Checking the@netlify/framework-info package innode_modules I noticed that it's packaged with its TypeScript declarations but is missingtypes property in itspackage.json file. This edit simply adds the missing property.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open abug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read thecontribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link
Contributor

@lukasholzerlukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@SevenOutman
Copy link
ContributorAuthor

Hi@lukasholzer, thank you for reviewing! I wonder if this PR is going be released soon?

@lukasholzer
Copy link
Contributor

@SevenOutman we can release it once it's merged ;) Just need to get all checks passing :) Seems like the automerge was stuck because of a flaky test 😬

@kodiakhqkodiakhqbot merged commitb03c28e intonetlify:mainFeb 27, 2023
@SevenOutman
Copy link
ContributorAuthor

Thanks for the quick response and action!

@SevenOutmanSevenOutman deleted the fix/framework-info-dts branchFebruary 28, 2023 06:04
khendrikse pushed a commit that referenced this pull requestFeb 28, 2023
Co-authored-by: Lukas Holzer <lukas.holzer@netlify.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lukasholzerlukasholzerlukasholzer approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find@netlify/framework-info type declarations
2 participants
@SevenOutman@lukasholzer

[8]ページ先頭

©2009-2025 Movatter.jp