- Notifications
You must be signed in to change notification settings - Fork71
fix(framework-info): add missing types in package.json#4873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Hi@lukasholzer, thank you for reviewing! I wonder if this PR is going be released soon? |
@SevenOutman we can release it once it's merged ;) Just need to get all checks passing :) Seems like the automerge was stuck because of a flaky test 😬 |
Thanks for the quick response and action! |
Co-authored-by: Lukas Holzer <lukas.holzer@netlify.com>
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes#4872
I'm using
@netlify/framework-info
in a TypeScript project and the compiler complains "Cannot find module or declaration".Checking the
@netlify/framework-info
package innode_modules
I noticed that it's packaged with its TypeScript declarations but is missingtypes
property in itspackage.json
file. This edit simply adds the missing property.For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)