- Notifications
You must be signed in to change notification settings - Fork783
Adjust newFactory method visibility#1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
taylorotwell merged 1 commit intolaravel:12.xfrombrandonfarber:bugfix/method-inheritance-visibilityApr 5, 2024
Merged
Adjust newFactory method visibility#1735
taylorotwell merged 1 commit intolaravel:12.xfrombrandonfarber:bugfix/method-inheritance-visibilityApr 5, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This method overrides the newFactory() method in the HasFactory trait, which is protected, resulting in a fatal error in PHP 8.3
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP: 8.3.4
Laravel Framework: 11.2.0
Laravel Passport: 12.0.2
At command line, attempting to create a client_credentials client from instructions in the documentation results in a PHP Fatal error.
The newFactory() method defined in the trait has a protected visibility, while the method has a public visibility in this class implementing the trait, resulting in a visibility compatibility error. The
as
operator could be used to adjust the method visibility, but this seemed like the better, clearer and more straightforward approach.