Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[12.x] Render newlines in query tooltip#57310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@faisuc
Copy link
Contributor

This fixes frontend breakage on the exception renderer by escaping tooltip content and converting newlines to<br>. It applies to queries, formatted source, request headers, and routing values, preventing layout overlap and syntax highlighter glitches when tooltip content contains newlines.Fixes#57246.

No breaking changes. This affects only the debug exception renderer UI and does not change any APIs.

@taylorotwelltaylorotwell marked this pull request as draftOctober 8, 2025 20:53
@crynobone
Copy link
Member

Fixed failling tests

@avosalmon
Copy link
Contributor

This PR wouldn't fix#57246. The tooltip is not causing the issue, but text truncation is broken on syntax-highlighted queries. I opened a PR to fix text truncation.#57315

Having said that, I think it's still nice to render newlines in the tooltip.

@avosalmonavosalmon changed the titleFix/exceptions renderer tooltip newlines escape[12.x] Render newlines in query tooltipOct 9, 2025
@faisucfaisuc marked this pull request as ready for reviewOctober 16, 2025 03:52
@taylorotwelltaylorotwell merged commitfecda76 intolaravel:12.xOct 16, 2025
64 of 65 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@crynobonecrynobonecrynobone left review comments

@avosalmonavosalmonavosalmon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New lines in querys in exception page breaks frontend and built-in syntax on the page

4 participants

@faisuc@crynobone@avosalmon@taylorotwell

[8]ページ先頭

©2009-2025 Movatter.jp