NotificationsYou must be signed in to change notification settings
Fork11.5k
Star33.9k

[12.x] when a method returns`$this` set the return type to`static`#56092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

taylorotwell merged 1 commit intolaravel:12.xfrombrowner12:AB-self-vs-static

Jun 22, 2025

Merged

[12.x] when a method returns`$this` set the return type to`static`#56092

taylorotwell merged 1 commit intolaravel:12.xfrombrowner12:AB-self-vs-static

Jun 22, 2025

Conversation

Copy link

Contributor

browner12 commentedJun 20, 2025

while PHP is a little lenient here, the more accurate return type when returning$this is static, not self.

when returningnew static() the return type should also bestatic overself.

this may be a little pedantic, but it should be slightly more accurate. also this is forward looking in case PHP ever decided to get more strict in their type checks regarding these return types.

when a method returns$this set the return type tostatic

1dbd8df

while PHP is a little lenient here, the more accurate return type when returning `$this` is static, not self.when returning `new static()` the return type should also be `static` over `self`.