Movatterモバイル変換

Skip to content

jquense/yupPublic

NotificationsYou must be signed in to change notification settings
Fork942
Star23.5k

fix: add optional message to nonNullable schema methods#2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

jquense merged 1 commit intojquense:masterfromranquild:master

Dec 27, 2023

Merged

fix: add optional message to nonNullable schema methods#2119

jquense merged 1 commit intojquense:masterfromranquild:master

Dec 27, 2023

Conversation

ranquild

Copy link

Contributor

ranquild commentedOct 7, 2023

Fixes#2069

Adds an optionalmsg?: Message argument tononNullable method on every schema object. The argument is already supported by thebase Schema class, and we only need to pass it properly with TypeScript.

Also updatesnullable andnonNullable signatures inREADME.md.

@ranquild

fix: add optional message to nonNullable schema methods

9478998

@ranquild

Copy link

ContributorAuthor

ranquild commentedNov 5, 2023

@jquense could you take a look, please?

@lmarvaud

Copy link

lmarvaud commentedDec 15, 2023

Hello,

It seem that the typing of "notNullable" and "nullable" had been swaped. InSchema.ts, inherited by few validators, only nonNullable takes a parameter.

yup/src/schema.ts

Lines 710 to 715 in5db2b2f

	nullable():any{
	returnthis.nullability(true);
	}
	nonNullable(message=locale.notNull):any{
	returnthis.nullability(false,message);
	}

Actually wouldn't it be cleaner to add those types in theSchema interface, to avoid code duplication and those type of error ?

jquense

jquense approved these changes

View reviewed changes

@jquense

jquense merged commit9e1df49 intojquense:master

@jquense

Copy link

Owner

jquense commentedDec 27, 2023

thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

3 participants

@ranquild

@lmarvaud

@jquense

[8]ページ先頭

©2009-2025 Movatter.jp