NotificationsYou must be signed in to change notification settings
Fork6.6k
Star45.1k

Fix ESM TS config loading in a CJS project#15694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cpojer merged 5 commits intojestjs:mainfromphryneas:pr/fix-esm-ts-in-cjs-project

Jun 25, 2025

Merged

Fix ESM TS config loading in a CJS project#15694

cpojer merged 5 commits intojestjs:mainfromphryneas:pr/fix-esm-ts-in-cjs-project

Jun 25, 2025

Conversation

Copy link

Contributor

phryneas commentedJun 23, 2025

Summary

This wouldfix#15682 where ESM in a.ts config file in atype: "commonjs" would error.

This has some alternatives:

what this PR does
going further than this PR and retrying to runloadTSConfigFile afterany error, without rethrowing (this would change error messages for some of the other tests with invalid syntax)
not solving this and instead encourage people to rename theirjest.config.ts tojest.config.mts, whichshould even work in a CommonJS project without any code changes on jest's side

Please make a call here - I don't have a strong opinion either way :)

Test plan

I added a test.

Fix ESM TS config loading in a CJS project

305bd71

Copy link

netlifybot commentedJun 23, 2025•
edited
Loading

✅ Deploy Preview forjestjs ready!

Builtwithout sensitive environment variables

Name	Link
🔨 Latest commit	`55f554e`
🔍 Latest deploy log	https://app.netlify.com/projects/jestjs/deploys/685b4d908340a50008671597
😎 Deploy Preview	https://deploy-preview-15694--jestjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to yourNetlify project configuration.

phryneas mentioned this pull request

Jun 23, 2025

[Bug]: jest.config.ts parsing broken on node 24 + CJS#15682

Closed

Copy link

pkg-pr-newbot commentedJun 23, 2025•
edited
Loading

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15694

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15694

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15694

create-jest

npm i https://pkg.pr.new/create-jest@15694

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15694

expect

npm i https://pkg.pr.new/expect@15694

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15694

jest

npm i https://pkg.pr.new/jest@15694

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15694

jest-circus

npm i https://pkg.pr.new/jest-circus@15694

jest-cli

npm i https://pkg.pr.new/jest-cli@15694

jest-config

npm i https://pkg.pr.new/jest-config@15694

@jest/console

npm i https://pkg.pr.new/@jest/console@15694

@jest/core

npm i https://pkg.pr.new/@jest/core@15694

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15694

jest-diff

npm i https://pkg.pr.new/jest-diff@15694

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15694

jest-each

npm i https://pkg.pr.new/jest-each@15694

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15694

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15694

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15694

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15694

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15694

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15694

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15694

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15694

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15694

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15694

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15694

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15694

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15694

jest-mock

npm i https://pkg.pr.new/jest-mock@15694

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15694

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15694

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15694

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15694

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15694

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15694

jest-runner

npm i https://pkg.pr.new/jest-runner@15694

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15694

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15694

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15694

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15694

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15694

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15694

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15694

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15694

@jest/types

npm i https://pkg.pr.new/@jest/types@15694

jest-util

npm i https://pkg.pr.new/jest-util@15694

jest-validate

npm i https://pkg.pr.new/jest-validate@15694

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15694

jest-worker

npm i https://pkg.pr.new/jest-worker@15694

pretty-format

npm i https://pkg.pr.new/pretty-format@15694

commit:55f554e

cpojer reviewed

Jun 25, 2025

View reviewed changes

packages/jest-config/src/readConfigFileAndSetRootDir.ts OutdatedShow resolvedHide resolved

Update packages/jest-config/src/readConfigFileAndSetRootDir.ts

bd89722

cpojer reviewed

Jun 25, 2025

View reviewed changes

packages/jest-config/src/readConfigFileAndSetRootDir.ts OutdatedShow resolvedHide resolved

Update packages/jest-config/src/readConfigFileAndSetRootDir.ts

78b5c53

cpojer reviewed

Jun 25, 2025

View reviewed changes

packages/jest-config/src/readConfigFileAndSetRootDir.ts OutdatedShow resolvedHide resolved

Update packages/jest-config/src/readConfigFileAndSetRootDir.ts

34a0aa5

cpojer reviewed

Jun 25, 2025

View reviewed changes

packages/jest-config/src/readConfigFileAndSetRootDir.ts OutdatedShow resolvedHide resolved

Update packages/jest-config/src/readConfigFileAndSetRootDir.ts

55f554e

cpojer approved these changes

Jun 25, 2025

View reviewed changes

Copy link

Member

cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good aber Sätze beginnt man immer noch mit Großbuchstaben.

cpojer merged commitd3efda6 intojestjs:main

Jun 25, 2025

39 of 53 checks passed

phryneas mentioned this pull request

Jul 6, 2025

more thorough fallback to ts loaders if node TypeScript support doesn't work out#15720

Merged

Copy link

github-actionsbot commentedJul 26, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend usingStackOverflow or ourdiscord channel for questions.

github-actionsbot locked asresolvedand limited conversation to collaborators

Jul 26, 2025

Labels

None yet

Movatterモバイル変換

Uh oh!

Fix ESM TS config loading in a CJS project#15694

Fix ESM TS config loading in a CJS project#15694

Uh oh!

Conversation

phryneas commentedJun 23, 2025

Summary

Test plan

Uh oh!

netlifybot commentedJun 23, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview forjestjs ready!

Uh oh!

pkg-pr-newbot commentedJun 23, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cpojer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actionsbot commentedJul 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlifybot commentedJun 23, 2025•
edited
Loading

pkg-pr-newbot commentedJun 23, 2025•
edited
Loading