Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Fix]order: codify invariants from docs into config schema#3152

Merged
ljharb merged 1 commit intoimport-js:mainfrom
Xunnamius:contrib-schema
Jun 20, 2025
Merged

[Fix]order: codify invariants from docs into config schema#3152
ljharb merged 1 commit intoimport-js:mainfrom
Xunnamius:contrib-schema

Conversation

@Xunnamius
Copy link
Contributor

@XunnamiusXunnamius commentedJan 26, 2025
edited
Loading

Updating schema wrt#3127 (comment)

EDIT: depends on#3129 for its added tests

@ljharb
Copy link
Member

This PR seems to have too much stuff in it - but either way, if a rule or option is already released, its schema can’t be tightened further.

@Xunnamius
Copy link
ContributorAuthor

Xunnamius commentedJan 27, 2025
edited
Loading

@ljharb It seems like it has a lot because it's on top of theconsolidateIslands PR (rather than main so the schema changes can run against the latest tests), but the two new commits are tiny and only touch the schema and two tests. I can pull the lines arounddependencies/consolidateIslands one commit up into theconsolidateIslands PR if desired :)

EDIT: I can also rebase onto main and decouple from the other PRs, but not hitting all the new tests plus no direct tests of the schema makes me a bit nervous.

As for the tightening of existing options, I assume you're talking about lines 865 and 866 forpathGroupsExcludedImportTypes? I can revert those. I did add a comment to thegroups schema warning that additional validation happens elsewhere, and added two newlines to thenamed schema for consistency, but those changes should be just cosmetic.

@ljharb
Copy link
Member

In that case, I'll wait to review this since it needs to wait on#3129

Xunnamius reacted with thumbs up emoji

@ljharbljharb marked this pull request as draftJanuary 27, 2025 05:49
Copy link
Member

@ljharbljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

these changes are non-breakingiff they exclude things that the rule already checks.

… which would also imply there's some code that can be removed, since the checks are not guaranteed to be done by eslint?

Xunnamius reacted with thumbs up emoji
@codecov
Copy link

codecovbot commentedJan 31, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base(4f145a2) to head(a73a2f2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3152      +/-   ##==========================================+ Coverage   95.17%   95.63%   +0.45%==========================================  Files          83       83                Lines        3688     3687       -1       Branches     1331     1330       -1     ==========================================+ Hits         3510     3526      +16+ Misses        178      161      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb
Copy link
Member

I just rebased this, and took a look - can you remind me why removing tests isn't a breaking change?

@Xunnamius
Copy link
ContributorAuthor

IIRC, those tests were removed because the validation code they were testing was removed (at your request), because we're relying on eslint and json schema for validation previously provided by that code.

The error messages will change to eslint's.

@ljharb
Copy link
Member

Perfect, thank you :-)

Xunnamius reacted with heart emoji

@ljharbljharb merged commit9e1ad6b intoimport-js:mainJun 20, 2025
363 of 364 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestJun 22, 2025
| datasource | package              | from   | to     || ---------- | -------------------- | ------ | ------ || npm        | eslint-plugin-import | 2.31.0 | 2.32.0 |## [v2.32.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2320---2025-06-20)##### Added- add \[`enforce-node-protocol-usage`] rule and `import/node-version` setting (\[[#3024](import-js/eslint-plugin-import#3024)], thanks \[[@GoldStrikeArch](https://github.com/GoldStrikeArch)] and \[[@sevenc-nanashi](https://github.com/sevenc-nanashi)])- add TypeScript types (\[[#3097](import-js/eslint-plugin-import#3097)], thanks \[[@G-Rath](https://github.com/G-Rath)])- \[`extensions`]: add \`pathGroupOverrides to allow enforcement decision overrides based on specifier (\[[#3105](import-js/eslint-plugin-import#3105)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])- \[`order`]: add `sortTypesGroup` option to allow intragroup sorting of type-only imports (\[[#3104](import-js/eslint-plugin-import#3104)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])- \[`order`]: add `newlines-between-types` option to control intragroup sorting of type-only imports (\[[#3127](import-js/eslint-plugin-import#3127)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])- \[`order`]: add `consolidateIslands` option to collapse excess spacing for aesthetically pleasing imports (\[[#3129](import-js/eslint-plugin-import#3129)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])##### Fixed- \[`no-unused-modules`]: provide more meaningful error message when no .eslintrc is present (\[[#3116](import-js/eslint-plugin-import#3116)], thanks \[[@michaelfaith](https://github.com/michaelfaith)])- configs: added missing name attribute for eslint config inspector (\[[#3151](import-js/eslint-plugin-import#3151)], thanks \[[@NishargShah](https://github.com/NishargShah)])- \[`order`]: ensure arcane imports do not cause undefined behavior (\[[#3128](import-js/eslint-plugin-import#3128)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])- \[`order`]: resolve undefined property access issue when using `named` ordering (\[[#3166](import-js/eslint-plugin-import#3166)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])- \[`enforce-node-protocol-usage`]: avoid a crash with some TS code (\[[#3173](import-js/eslint-plugin-import#3173)], thanks \[[@ljharb](https://github.com/ljharb)])- \[`order`]: codify invariants from docs into config schema (\[[#3152](import-js/eslint-plugin-import#3152)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])##### Changed- \[Docs] \[`extensions`], \[`order`]: improve documentation (\[[#3106](import-js/eslint-plugin-import#3106)], thanks \[[@Xunnamius](https://github.com/Xunnamius)])- \[Docs] add flat config guide for using `tseslint.config()` (\[[#3125](import-js/eslint-plugin-import#3125)], thanks \[[@lnuvy](https://github.com/lnuvy)])- \[Docs] add missing comma (\[[#3122](import-js/eslint-plugin-import#3122)], thanks \[[@RyanGst](https://github.com/RyanGst)])- \[readme] Update flatConfig example to include typescript config (\[[#3138](import-js/eslint-plugin-import#3138)], thanks \[[@intellix](https://github.com/intellix)])- \[Refactor] \[`order`]: remove unnecessary negative check (\[[#3167](import-js/eslint-plugin-import#3167)], thanks \[[@JounQin](https://github.com/JounQin)])- \[Docs] \[`no-unused-modules`]: add missing double quote (\[[#3191](import-js/eslint-plugin-import#3191)], thanks \[[@albertpastrana](https://github.com/albertpastrana)])- \[Docs] `no-restricted-paths`: clarify wording and fix errors (\[[#3172](import-js/eslint-plugin-import#3172)], thanks \[[@greim](https://github.com/greim)])
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xunnamius@ljharb

[8]ページ先頭

©2009-2026 Movatter.jp