- Notifications
You must be signed in to change notification settings - Fork4.4k
Backport of Remove SA Credentials from DB Connection Details on Read into release/1.15.x#23257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
vinay-gopalan merged 1 commit intorelease/1.15.xfrombackport/cloudsql-iam-credentials-read/amazingly-smooth-elephantSep 22, 2023
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4e439e0 to7b77825Compare035a8ac to378cf4aComparevinay-gopalan approved these changesSep 22, 2023
Build Results: |
CI Results: |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
hashicorp-contributed-prIf the PR is HashiCorp (i.e. not-community) contributed
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from#23256 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
Removes the
service_account_jsonparameter when reading DB connection details from Vault, similar to what we are doing forpasswordandprivate_key. For the DBs that don't have this parameter, this will be a no-op.Overview of commits