Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

statecheck: AddExpectIdentity state check for asserting an entire identity object#470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
austinvalle merged 5 commits intomainfromav/expect-identity
Mar 26, 2025

Conversation

austinvalle
Copy link
Member

Follow up to#468

Some initial feedback rightfully pointed out that it's likely that providers will want to assert the entire identity object as a single check, rather than multiplestatecheck.ExpectIdentityValue checks. We can have both, so this PR introduces the object-level check (similar toknownvalue.ObjectExact).

This PR also uses theValueType method that was recently updated interraform-plugin-go@main ->hashicorp/terraform-plugin-go#497

@austinvalleaustinvalle requested a review froma team as acode ownerMarch 25, 2025 21:44
@austinvalleaustinvalle added this to thev1.13.0 milestoneMar 25, 2025
@austinvalleaustinvalle added the enhancementNew feature or request labelMar 25, 2025
bbasata
bbasata previously approved these changesMar 26, 2025
Copy link
Collaborator

@bbasatabbasata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

One suggestion in line comments

Copy link
Collaborator

@bbasatabbasata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@austinvalleaustinvalle merged commit5dd7333 intomainMar 26, 2025
40 checks passed
@austinvalleaustinvalle deleted the av/expect-identity branchMarch 26, 2025 13:10
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 25, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bbasatabbasatabbasata approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

v1.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@austinvalle@bbasata

[8]ページ先頭

©2009-2025 Movatter.jp