- Notifications
You must be signed in to change notification settings - Fork16
statecheck: AddExpectIdentity
state check for asserting an entire identity object#470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One suggestion in line comments
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
5dd7333
intomainUh oh!
There was an error while loading.Please reload this page.
Follow up to#468
Some initial feedback rightfully pointed out that it's likely that providers will want to assert the entire identity object as a single check, rather than multiple
statecheck.ExpectIdentityValue
checks. We can have both, so this PR introduces the object-level check (similar toknownvalue.ObjectExact
).This PR also uses the
ValueType
method that was recently updated interraform-plugin-go@main
->hashicorp/terraform-plugin-go#497