- Notifications
You must be signed in to change notification settings - Fork242
helper/schema: Add validation to prevent write-only attributes in set nested blocks#1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
75f6c6e tocca1351Compare
SBGoods left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Failing CI checks will be resolved after#1428 is merged
austinvalle left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think wehave to repeat this changelog, but I'm not expressly against it 😆
| true, | ||
| }, | ||
| "Set configuration block nested attribute with WriteOnly set returnsno errors": { | ||
| "Set configuration block nested attribute with WriteOnly set returnserror": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice that we already had tests for it!
b7f3e6f intomainUh oh!
There was an error while loading.Please reload this page.
Write-only attributes when used with ephemeral data cannot be used within any set and set-based data due to limitations in Terraform Core. This PR adds validation to block write-only attributes from being used within set nested blocks.