Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ResourceIdentity: Add support for import by identity and update pass-through implementations#1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
austinvalle merged 4 commits intomainfromav/import-identity
Apr 14, 2025

Conversation

austinvalle
Copy link
Member

This PR adds support for plannable import by resource identity, which is first supported in Terraformv1.12.0-beta1.


Today, the only supported plannable import data is theid field, which is just a string that provider typically just redirects to theimport stub state:

import {to=aws_route53_record.myrecordid="Z4KAPRWWNC7JR_dev.example.com_NS"}

Now, if the resource supports identity, the import block will allow the identity to be supplied in theidentity attribute:

import {to=aws_route53_record.myrecordidentity={    zone_id="Z4KAPRWWNC7JR"    record_name="dev.example.com"    record_type="NS"  }}

The identity is automatically passed through to theRead implementation, which typically does the heavy lifting for populating state of an imported resource, however the provider can choose to populate the identity with more information, set data in the import stub state, etc.

@austinvalleaustinvalle added the enhancementNew feature or request labelApr 3, 2025
@austinvalleaustinvalle added this to thev1.15.0 milestoneApr 3, 2025
@austinvalleaustinvalle requested a review froma team as acode ownerApril 3, 2025 16:09
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One thing not included in this PR is an implementation of an "identity => import stub state" pass-through. I'm still not 100% sure what provider developers will prefer in-terms of helper functions, but we can easily create a new one if needed.

bbasata reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My plan was to release a framework1.15.0-beta.1 with this PR (along with Rain's currently open#1125 and#1123 )

bbasata reacted with rocket emoji
Copy link
Contributor

@bbasatabbasata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@austinvalleaustinvalle merged commitdb08a72 intomainApr 14, 2025
36 checks passed
@austinvalleaustinvalle deleted the av/import-identity branchApril 14, 2025 20:38
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bbasatabbasatabbasata approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

v1.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@austinvalle@bbasata

[8]ページ先頭

©2009-2025 Movatter.jp