NotificationsYou must be signed in to change notification settings
Fork29
Star171

go: Bump to 1.25#168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

radeksimko merged 1 commit intomainfrombump-go-to-1.24

Aug 13, 2025

Merged

go: Bump to 1.25#168

radeksimko merged 1 commit intomainfrombump-go-to-1.24

Aug 13, 2025

Conversation

Copy link

Member

radeksimko commentedAug 13, 2025•
edited
Loading

Description

This removes Go 1.18 and 1.19 as testing targets in our CI. Asgo.mod communicates, our minimum version is already set to 1.21 anyway but it wasn't until#167 that tests on these versions started failing.

I couldn't match a particular change in theGo 1.20 changelog to understand why exactly - it seems that older Go versions had some different/buggyencoding/json which fails to decode bytes into struct which only has an embedded struct, such as the one in the linked PR:

typeLogMessagestruct {baseLogMessage}

We could also remove 1.20 from the test matrix but since tests in this repo are generally very fast I opted to keep running them for now until we have a strong enough reason to remove them (when they start failing) 🤷🏻‍♂️