Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Initial support for provider-defined functions from providers schema -json#119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
radeksimko merged 2 commits intomainfrombflad/provider-functions
Jan 19, 2024

Conversation

bflad
Copy link
Contributor

Closes#118
Reference:hashicorp/terraform#34450

The Terraformproviders schema -json output implementation currently uses the entiremetadata functions -json implementation, so has the additional nesting layer containingformat_version andfunction_signatures.

…-jsonReference:#118Reference:hashicorp/terraform#34450The Terraform `providers schema -json` output implementation currently uses the entire `metadata functions -json` implementation, so has the additional nesting layer containing `format_version` and `function_signatures`.
@bfladbflad requested review froma team ascode ownersJanuary 11, 2024 22:47
@bfladbflad added the enhancementNew feature or request labelJan 11, 2024
Copy link
Contributor

@bendbennettbendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚀

@bflad
Copy link
ContributorAuthor

There are still some discussions on whether the "extra" object containing theformat_version/function_signatures properties should be in theproviders schema -json output. It wasn't in the RFC and could be confusing. Once all that is sorted will make any changes and merge after a 👍 from core.

Copy link
Member

@radeksimkoradeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@radeksimkoradeksimko merged commitf2686e9 intomainJan 19, 2024
@radeksimkoradeksimko deleted the bflad/provider-functions branchJanuary 19, 2024 10:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@radeksimkoradeksimkoradeksimko approved these changes

@SBGoodsSBGoodsSBGoods approved these changes

+1 more reviewer

@bendbennettbendbennettbendbennett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Provider-Defined Functions

4 participants

@bflad@radeksimko@bendbennett@SBGoods

[8]ページ先頭

©2009-2025 Movatter.jp