- Notifications
You must be signed in to change notification settings - Fork4.5k
channelz: add LocalAddr to listen sockets and test#7062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedMar 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## master #7062 +/- ##==========================================+ Coverage 82.49% 82.58% +0.08%========================================== Files 300 300 Lines 31351 31357 +6 ==========================================+ Hits 25864 25896 +32+ Misses 4434 4409 -25+ Partials 1053 1052 -1
|
For posterity: the regression introduced in#6969, internal ref b/330220025. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM outside minor nit. We should trigger an adhoc interop run to see if this fixes.
test/channelz_test.go Outdated
| return false, fmt.Errorf("server want id %d, but got %d", serverID, srv.ID) | ||
| } | ||
| skts := srv.ListenSockets() | ||
| if got, want := len(skts), 1; got != want { | ||
| return false, fmt.Errorf("server has %v sockets; want %v", got, want) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Optional nit: keep consistent with go style guide and also I prefer consistent format across errors (and our codebase):https://g3doc.corp.google.com/go/g3doc/style/decisions.md?cl=head#got-before-want
c003fdf intogrpc:masterUh oh!
There was an error while loading.Please reload this page.
Merged; hopefully tests pass now :) |
RELEASE NOTES: none