- Notifications
You must be signed in to change notification settings - Fork61
Provideno-redundant-roles exception forrowgroup#531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
accessibility-bot commentedJun 4, 2024
👋 Hello and thanks for pinging us! You've entered ourfirst responder queue. An accessibility first responder will review this soon.
|
TylerJDev approved these changesJun 4, 2024
TylerJDev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, thanks a ton too! ✨
| 'jsx-a11y/no-redundant-roles': [ | ||
| 'error', | ||
| { | ||
| nav: ['navigation'], // default in eslint-plugin-jsx-a11y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just curious, is this needed because the object is overridden when we provide our own config/mapping? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, that is correct!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Or at least thats how I remember it.. let me double check 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If I'm interpreting thelogic correctly, it looks like the rule will use the default{ nav: ['navigation']}if the consumer isn't already passing an alternate option! This seems fine to keep!
8d9ed4f intomain 4 checks passed
Uh oh!
There was an error while loading.Please reload this page.
4 tasks
WtfJoke referenced this pull request in WtfJoke/setup-groovyAug 1, 2024
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---||[eslint-plugin-github](https://togithub.com/github/eslint-plugin-github)| [`4.10.2` ->`5.0.1`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.10.2/5.0.1)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>github/eslint-plugin-github (eslint-plugin-github)</summary>###[`v5.0.1`](https://togithub.com/github/eslint-plugin-github/releases/tag/v5.0.1)[CompareSource](https://togithub.com/github/eslint-plugin-github/compare/v5.0.0...v5.0.1)#### What's Changed- chore(deps): bump the all-dependencies group with 5 updates by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/530](https://togithub.com/github/eslint-plugin-github/pull/530)- Provide `no-redundant-roles` exception for `rowgroup` by[@​khiga8](https://togithub.com/khiga8) in[https://github.com/github/eslint-plugin-github/pull/531](https://togithub.com/github/eslint-plugin-github/pull/531)**Full Changelog**:github/eslint-plugin-github@v5.0.0...v5.0.1###[`v5.0.0`](https://togithub.com/github/eslint-plugin-github/releases/tag/v5.0.0)[CompareSource](https://togithub.com/github/eslint-plugin-github/compare/v4.10.2...v5.0.0)Formally releasing v5.0.0!This release includes everything in pre-release[v5.0.0-2](https://togithub.com/github/eslint-plugin-github/releases/tag/v5.0.0-2)!We notably dropped support for node 14 and node 16 in favor of node 18.#### What's Changed- Drop node 14/16 support and fix bug in `getElementType` logic by[@​khiga8](https://togithub.com/khiga8) in[https://github.com/github/eslint-plugin-github/pull/525](https://togithub.com/github/eslint-plugin-github/pull/525)- Bump node 14 to node 18 by[@​khiga8](https://togithub.com/khiga8) in[https://github.com/github/eslint-plugin-github/pull/529](https://togithub.com/github/eslint-plugin-github/pull/529)- chore(deps): bump the all-dependencies group with 4 updates by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/510](https://togithub.com/github/eslint-plugin-github/pull/510)- chore(deps): bump the all-dependencies group with 2 updates by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/511](https://togithub.com/github/eslint-plugin-github/pull/511)- chore(deps): bump the all-dependencies group with 2 updates by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/512](https://togithub.com/github/eslint-plugin-github/pull/512)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/514](https://togithub.com/github/eslint-plugin-github/pull/514)- chore(deps): bump the all-dependencies group across 1 directory with 4updates by [@​dependabot](https://togithub.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/522](https://togithub.com/github/eslint-plugin-github/pull/522)</details>---### Configuration📅 **Schedule**: Branch creation - "before 4am on Monday" in timezoneEurope/Berlin, Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). View the[repository joblog](https://developer.mend.io/github/WtfJoke/setup-groovy).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
%5d(https%3a%2f%2frenovatebot.com){kind=link}
WtfJoke referenced this pull request in WtfJoke/setup-tectonicSep 13, 2024
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---||[eslint-plugin-github](https://redirect.github.com/github/eslint-plugin-github)| [`4.10.2` ->`5.0.2`](https://renovatebot.com/diffs/npm/eslint-plugin-github/4.10.2/5.0.2)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>github/eslint-plugin-github (eslint-plugin-github)</summary>###[`v5.0.2`](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.2)[CompareSource](https://redirect.github.com/github/eslint-plugin-github/compare/v5.0.1...v5.0.2)#### What's Changed- chore(deps): bump the all-dependencies group across 1 directory with 3updates by [@​dependabot](https://redirect.github.com/dependabot)in[https://github.com/github/eslint-plugin-github/pull/533](https://redirect.github.com/github/eslint-plugin-github/pull/533)- chore(deps): bump braces from 3.0.2 to 3.0.3 by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/534](https://redirect.github.com/github/eslint-plugin-github/pull/534)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/535](https://redirect.github.com/github/eslint-plugin-github/pull/535)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/536](https://redirect.github.com/github/eslint-plugin-github/pull/536)- chore(deps): bump the all-dependencies group with 4 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/537](https://redirect.github.com/github/eslint-plugin-github/pull/537)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/538](https://redirect.github.com/github/eslint-plugin-github/pull/538)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/540](https://redirect.github.com/github/eslint-plugin-github/pull/540)- chore(deps): bump the all-dependencies group with 4 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/541](https://redirect.github.com/github/eslint-plugin-github/pull/541)- chore(deps): bump the all-dependencies group across 1 directory with 3updates by [@​dependabot](https://redirect.github.com/dependabot)in[https://github.com/github/eslint-plugin-github/pull/543](https://redirect.github.com/github/eslint-plugin-github/pull/543)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/544](https://redirect.github.com/github/eslint-plugin-github/pull/544)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/545](https://redirect.github.com/github/eslint-plugin-github/pull/545)- chore(deps): bump the all-dependencies group across 1 directory with 4updates by [@​dependabot](https://redirect.github.com/dependabot)in[https://github.com/github/eslint-plugin-github/pull/551](https://redirect.github.com/github/eslint-plugin-github/pull/551)**Full Changelog**:github/eslint-plugin-github@v5.0.1...v5.0.2###[`v5.0.1`](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.1)[CompareSource](https://redirect.github.com/github/eslint-plugin-github/compare/v5.0.0...v5.0.1)#### What's Changed- chore(deps): bump the all-dependencies group with 5 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/530](https://redirect.github.com/github/eslint-plugin-github/pull/530)- Provide `no-redundant-roles` exception for `rowgroup` by[@​khiga8](https://redirect.github.com/khiga8) in[https://github.com/github/eslint-plugin-github/pull/531](https://redirect.github.com/github/eslint-plugin-github/pull/531)**Full Changelog**:github/eslint-plugin-github@v5.0.0...v5.0.1###[`v5.0.0`](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.0)[CompareSource](https://redirect.github.com/github/eslint-plugin-github/compare/v4.10.2...v5.0.0)Formally releasing v5.0.0!This release includes everything in pre-release[v5.0.0-2](https://redirect.github.com/github/eslint-plugin-github/releases/tag/v5.0.0-2)!We notably dropped support for node 14 and node 16 in favor of node 18.#### What's Changed- Drop node 14/16 support and fix bug in `getElementType` logic by[@​khiga8](https://redirect.github.com/khiga8) in[https://github.com/github/eslint-plugin-github/pull/525](https://redirect.github.com/github/eslint-plugin-github/pull/525)- Bump node 14 to node 18 by[@​khiga8](https://redirect.github.com/khiga8) in[https://github.com/github/eslint-plugin-github/pull/529](https://redirect.github.com/github/eslint-plugin-github/pull/529)- chore(deps): bump the all-dependencies group with 4 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/510](https://redirect.github.com/github/eslint-plugin-github/pull/510)- chore(deps): bump the all-dependencies group with 2 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/511](https://redirect.github.com/github/eslint-plugin-github/pull/511)- chore(deps): bump the all-dependencies group with 2 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/512](https://redirect.github.com/github/eslint-plugin-github/pull/512)- chore(deps): bump the all-dependencies group with 3 updates by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/github/eslint-plugin-github/pull/514](https://redirect.github.com/github/eslint-plugin-github/pull/514)- chore(deps): bump the all-dependencies group across 1 directory with 4updates by [@​dependabot](https://redirect.github.com/dependabot)in[https://github.com/github/eslint-plugin-github/pull/522](https://redirect.github.com/github/eslint-plugin-github/pull/522)</details>---### Configuration📅 **Schedule**: Branch creation - "before 4am on Monday" in timezoneEurope/Berlin, Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/WtfJoke/setup-tectonic).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Relates to:https://github.com/github/accessibility/issues/5304
Follow-up to:https://github.com/github/accessibility/discussions/4921
What
This PR adds an exception so that the
no-redundant-rolesrule does not flag redundant use ofrowgroupfor:<thead role="rowgroup"><tbody role="rowgroup">Why
There have been 3 reported instances of false positives raised by this rule. All of these relate to redundant usage of
role="rowgroup". Redundant usage ofrole="rowgroup"is necessary in some cases to ensure that table semantics are not dropped by screen readers.The reported instances are:
display: gridordisplay: contentsis used. Example -example in primer/reactIt seems appropriate to not flag redundant use of
role="rowgroup"for now. We can always revisit this in the future.Why don't we turn this rule off completely?
All the reported false positives are for
role="rowgroup"which we can except, so it does not seem worth turning the rule off completely.