- Notifications
You must be signed in to change notification settings - Fork48.9k
Restore server controlled form fields to whatever they should be#26708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
react-sizebot commentedApr 23, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Comparing:36e4cbe...fbcdceb Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
| @@ -131,7 +131,6 @@ export function updateInput( | |||
| // Submit/reset inputs need the attribute removed completely to avoid | |||
| // blank-text buttons. | |||
| node.removeAttribute('value'); | |||
| return; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I noticed that this return was problematic because we don't restore thename after setting it to empty.
sophiebits approved these changesApr 23, 2023
Fizz can emit whatever for the SSR version of these fields when it's afunction actual so they might not align with what is in the previous props.Therefore we need to force them to update if we're updating to a non-functionwhere they might be relevant again.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull requestApr 15, 2024
…ebook#26708)Fizz can emit whatever it wants for the SSR version of these fields whenit's a function action so they might not align with what is in theprevious props. Therefore we need to force them to update if we'reupdating to a non-function where they might be relevant again.
bigfootjon pushed a commit that referenced this pull requestApr 18, 2024
)Fizz can emit whatever it wants for the SSR version of these fields whenit's a function action so they might not align with what is in theprevious props. Therefore we need to force them to update if we'reupdating to a non-function where they might be relevant again.DiffTrain build for commit2fa6323.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fizz can emit whatever it wants for the SSR version of these fields when it's a function action so they might not align with what is in the previous props. Therefore we need to force them to update if we're updating to a non-function where they might be relevant again.