Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: remove formatting-related lint rules internally#19473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldbergJoshuaKGoldberg commentedMar 3, 2025
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: internal-only change

What changes did you make? (Give an overview)

Split out of#19354: removes all formatting-related lint rules from core. This way themain branch will not be broken by adding in formatting-related configuration settings in a different PR from the formatting changes themselves. See#19354.

Also updatestools/update-rule-type-headers.js to print tabs, since printing spaces will cause a conflict once the Prettier settings from#19354 &#19355 are applied.

Is there anything you'd like reviewers to focus on?

The intended merge order of PRs to avoidmain branch CI failures is:

  1. 👉chore: remove formatting-related lint rules internally #19473 (this one): to remove any CI check that would fail on the upcoming new formatting
  2. chore: formatted files with Prettier via trunk fmt #19355: applies new formatting rules, and should be squash-merged to make a single commit for.git-blame-ignore-revs
  3. chore: enabled Prettier in Trunk #19354: adds Prettier checks in CI and as commit hooks via Trunk

@netlifyNetlify
Copy link

netlifybot commentedMar 3, 2025
edited
Loading

Deploy Preview fordocs-eslint canceled.

NameLink
🔨 Latest commitaa89439
🔍 Latest deploy loghttps://app.netlify.com/sites/docs-eslint/deploys/67cf1cb824544300080c76cc

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewMarch 7, 2025 19:50
@JoshuaKGoldbergJoshuaKGoldberg requested a review froma team as acode ownerMarch 7, 2025 19:50
@eslint-github-boteslint-github-botbot added the choreThis change is not user-facing labelMar 10, 2025
nzakas
nzakas previously approved these changesMar 10, 2025
Copy link
Member

@nzakasnzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Just need to wait for the patch release window to pass.

@nzakasnzakas moved this fromNeeds Triage toMerge Candidates inTriageMar 10, 2025
@JoshuaKGoldberg
Copy link
ContributorAuthor

Sorry, found one last point I'd missed earlier:tools/update-rule-type-headers.js was still printing spaces in the.d.ts. Commit hooks added in the later PRs auto-switch them to tabs anyway but now that the PRs are split out & passingmain, it was failing the build in#19355. Plus it's a little messy IMO to print spaces when the repo is formatted with tabs.

Anyway, I believe the three PRs are split up so that merging them sequentially won't cause failures inmain. All three OPs are updated to indicate the order.

Copy link
Member

@nzakasnzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks.

@nzakasnzakas merged commit7a699a6 intoeslint:mainMar 11, 2025
31 checks passed
@github-project-automationgithub-project-automationbot moved this fromMerge Candidates toComplete inTriageMar 11, 2025
@JoshuaKGoldbergJoshuaKGoldberg deleted the remove-formatting-linting branchMarch 11, 2025 20:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nzakasnzakasnzakas approved these changes

Assignees
No one assigned
Labels
choreThis change is not user-facing
Projects
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@nzakas

[8]ページ先頭

©2009-2025 Movatter.jp