Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.8k
chore: remove formatting-related lint rules internally#19473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
netlifybot commentedMar 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fordocs-eslint canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Just need to wait for the patch release window to pass.
Sorry, found one last point I'd missed earlier: Anyway, I believe the three PRs are split up so that merging them sequentially won't cause failures in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks.
7a699a6
intoeslint:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: internal-only change
What changes did you make? (Give an overview)
Split out of#19354: removes all formatting-related lint rules from core. This way the
main
branch will not be broken by adding in formatting-related configuration settings in a different PR from the formatting changes themselves. See#19354.Also updates
tools/update-rule-type-headers.js to print tabs
, since printing spaces will cause a conflict once the Prettier settings from#19354 䮛 are applied.Is there anything you'd like reviewers to focus on?
The intended merge order of PRs to avoid
main
branch CI failures is:.git-blame-ignore-revs