Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.8k
docs: use higher contrast color tokens for code comments#19187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
docs: use higher contrast color tokens for code comments#19187
Uh oh!
There was an error while loading.Please reload this page.
Conversation
netlifybot commentedNov 27, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fordocs-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR!
But in no-js mode the color is still not bright can you please fix that also?
js mode
no-js mode
and CI is failing could it be because the branch is not up-to-date?
Ooh, interesting. That looks to me like a more root issue about text using light mode styles in dark mode when no-js is enabled. I think that's out of scope of this PR? |
Oh! I was wrong, code comments just aren't using the same dark/light mode queries as most of the app. Updated. |
07eac8a tob2fc957CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
a76f233 intoeslint:mainUh oh!
There was an error while loading.Please reload this page.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixeseslint/eslint.org#665. Corresponds toeslint/eslint.org#666.
What changes did you make? (Give an overview)
I swapped out the hardcoded comment colors with the closest theme tokens that had sufficient contrast.
Is there anything you'd like reviewers to focus on?
If there are other ad-hoc colors just barely off from color tokens, I'd be happy to clean those up in a followup?