Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.9k
docs: version selectors synchronization#18265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
netlifybot commentedApr 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fordocs-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
nzakas approved these changesApr 4, 2024
Member
nzakas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Just leaving open so@mdjermanovic can merge when ready.
MemberAuthor
mdjermanovic commentedApr 4, 2024
Safe to merge now, and we'll need this to testeslint/eslint.org#541. |
Vylpes pushed a commit to Vylpes/card-drop that referenced this pull requestSep 23, 2024
This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | patch | [`8.57.0` -> `8.57.1`](https://renovatebot.com/diffs/npm/eslint/8.57.0/8.57.1) |---### Release Notes<details><summary>eslint/eslint (eslint)</summary>### [`v8.57.1`](https://github.com/eslint/eslint/releases/tag/v8.57.1)[Compare Source](eslint/eslint@v8.57.0...v8.57.1)#### Bug Fixes- [`a19072f`](eslint/eslint@a19072f) fix: add logic to handle fixTypes in the lintText() method ([#​18900](eslint/eslint#18900)) (Francesco Trotta)- [`04c7188`](eslint/eslint@04c7188) fix: Don't lint same file multiple times ([#​18899](eslint/eslint#18899)) (Francesco Trotta)- [`87ec3c4`](eslint/eslint@87ec3c4) fix: do not throw when defining a global named `__defineSetter__` ([#​18898](eslint/eslint#18898)) (Francesco Trotta)- [`60a1267`](eslint/eslint@60a1267) fix: Provide helpful error message for nullish configs ([#​18889](eslint/eslint#18889)) (Milos Djermanovic)- [`a0dea8e`](eslint/eslint@a0dea8e) fix: allow `name` in global ignores, fix `--no-ignore` for non-global ([#​18875](eslint/eslint#18875)) (Milos Djermanovic)- [`3836bb4`](eslint/eslint@3836bb4) fix: do not crash on error in `fs.walk` filter ([#​18886](eslint/eslint#18886)) (Milos Djermanovic)- [`2dec349`](eslint/eslint@2dec349) fix: skip processor code blocks that match only universal patterns ([#​18880](eslint/eslint#18880)) (Milos Djermanovic)#### Documentation- [`6a5add4`](eslint/eslint@6a5add4) docs: v8.x Add EOL banner ([#​18744](eslint/eslint#18744)) (Amaresh S M)- [`b034575`](eslint/eslint@b034575) docs: v8.x add version support page to the dropdown ([#​18731](eslint/eslint#18731)) (Amaresh S M)- [`760ef7d`](eslint/eslint@760ef7d) docs: v8.x add version support page in the side navbar ([#​18740](eslint/eslint#18740)) (Amaresh S M)- [`428b7ea`](eslint/eslint@428b7ea) docs: Add Powered by Algolia label to the search ([#​18658](eslint/eslint#18658)) (Amaresh S M)- [`c68c07f`](eslint/eslint@c68c07f) docs: version selectors synchronization ([#​18265](eslint/eslint#18265)) (Milos Djermanovic)#### Build Related- [`35d366a`](eslint/eslint@35d366a) build: Support updates to previous major versions ([#​18870](eslint/eslint#18870)) (Milos Djermanovic)#### Chores- [`140ec45`](eslint/eslint@140ec45) chore: upgrade [@​eslint/js](https://github.com/eslint/js)[@​8](https://github.com/8).57.1 ([#​18913](eslint/eslint#18913)) (Milos Djermanovic)- [`bcdfc04`](eslint/eslint@bcdfc04) chore: package.json update for [@​eslint/js](https://github.com/eslint/js) release (Jenkins)- [`3f6ce8d`](eslint/eslint@3f6ce8d) chore: pin vite-plugin-commonjs@0.10.1 ([#​18910](eslint/eslint#18910)) (Milos Djermanovic)- [`9f07549`](eslint/eslint@9f07549) chore: ignore `/docs/v8.x` in link checker ([#​18660](eslint/eslint#18660)) (Milos Djermanovic)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=-->Reviewed-on:https://git.vylpes.xyz/External/card-drop/pulls/366Reviewed-by: Vylpes <ethan@vylpes.com>Co-authored-by: Renovate Bot <renovate@vylpes.com>Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
acceptedThere is consensus among the team that this change meets the criteria for inclusion archived due to ageThis issue has been archived; please open a new issue for any further discussion documentationRelates to ESLint's documentation
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This intentionally targets the
v8.xbranch.Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Ports#18260 to v8.x.
What changes did you make? (Give an overview)
Copied docs/ changes from#18260.
Build-related changes are intentionally omitted as they're not important for this branch.
The following code is also intentionally omitted as it was necessary only for testing of#18260 (I'll remove it from the
mainbranch as well):eslint/docs/src/_data/eslintVersions.js
Lines 31 to 35 in96607d0
The same for
docs/src/_data/versions.json.Is there anything you'd like reviewers to focus on?
If we'll release another prerelease this week, I'll manually sync the- edit: no need for updating thelatestbranch with thev8.xbranch when this is merged.latestbranch manually as we're releasing v9.0.0 final and thelatestbranch will be synced with themainbranch where this has already been implemented.