Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix Assert.Throws to validate parameter names#7007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stephentoub merged 2 commits intodotnet:mainfromstephentoub:fixasserts
Nov 4, 2025

Conversation

@stephentoub
Copy link
Member

@stephentoubstephentoub commentedNov 3, 2025•
edited by dotnet-policy-servicebot
Loading

Microsoft Reviewers:Open in CodeFlow

CopilotAI review requested due to automatic review settingsNovember 3, 2025 22:32
@stephentoubstephentoub requested review froma team ascode ownersNovember 3, 2025 22:32
@stephentoubstephentoubenabled auto-merge (squash)November 3, 2025 22:32
@github-actionsgithub-actionsbot added the area-aiMicrosoft.Extensions.AI libraries labelNov 3, 2025
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR enhances test quality and fixes encoding issues across AI-related test files. The changes add parameter name arguments toAssert.Throws calls for better test diagnostics and correct character encoding in test data.

Key changes:

  • Added parameter name arguments toAssert.Throws assertions across multiple test files for clearer error messages
  • Fixed character encoding from� to° for degree symbols in temperature strings
  • UpdatedHostedFileContent constructor to useThrow.IfNullOrWhitespace for consistent validation

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
SummarizingChatReducerTests.csAdded parameter names to exception assertions for constructor validation tests
MessageCountingChatReducerTests.csAdded parameter names to exception assertions and fixed degree symbol encoding
ToolReductionTests.csAdded parameter name toArgumentOutOfRangeException assertion
NGramTests.csAdded parameter names to multiple exception assertions
AIJsonUtilitiesTests.csAdded parameter names to exception assertions for validation tests
AIJsonSchemaTransformCacheTests.csAdded parameter names to exception assertions
HostedVectorStoreContentTests.csAdded parameter names to exception assertions for constructor and property validation
HostedFileContentTests.csAdded parameter names to exception assertions for constructor and property validation
HostedFileContent.csUpdated constructor to useThrow.IfNullOrWhitespace for consistent validation

@stephentoubstephentoub merged commit57004d9 intodotnet:mainNov 4, 2025
6 checks passed
This was referencedNov 11, 2025
This was referencedNov 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@shyamnamboodiripadshyamnamboodiripadshyamnamboodiripad approved these changes

Assignees

@stephentoubstephentoub

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephentoub@shyamnamboodiripad
[8]ページ先頭
©2009-2025 Movatter.jp