Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Introduce Markdown readers#6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
adamsitnik merged 17 commits intodotnet:mainfromadamsitnik:markdownReaders
Oct 31, 2025
Merged

Conversation

@adamsitnik
Copy link
Member

@adamsitnikadamsitnik commentedOct 27, 2025•
edited by dotnet-policy-servicebot
Loading

Microsoft Reviewers:Open in CodeFlow

CopilotAI review requested due to automatic review settingsOctober 27, 2025 16:43
@adamsitnikadamsitnik requested a review froma team as acode ownerOctober 27, 2025 16:43
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces Markdown reading capabilities to the data ingestion library through two new readers:MarkdownReader for native Markdown files andMarkItDownReader that leverages the external MarkItDown tool to convert various document formats to Markdown before parsing.

Key changes:

  • AddsMarkdownReader for parsing.md files using the Markdig library
  • AddsMarkItDownReader that wraps the MarkItDown CLI tool to convert documents (PDF, DOCX, etc.) to Markdown
  • Introduces sharedMarkdownParser to parse Markdig AST intoIngestionDocument model
  • Implements comprehensive test suite with conformance tests and format-specific test cases

Reviewed Changes

Copilot reviewed 12 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
MarkdownReader.csImplements reader for native Markdown files using Markdig parser
MarkdownParser.csCore parsing logic converting Markdig AST to IngestionDocument model
MarkItDownReader.csWraps MarkItDown CLI tool to convert various document formats to Markdown
Microsoft.Extensions.DataIngestion.Markdown.csprojProject file for MarkdownReader with Markdig dependency
Microsoft.Extensions.DataIngestion.MarkItDown.csprojProject file for MarkItDownReader, shares MarkdownParser code
DocumentReaderConformanceTests.csBase test class defining conformance tests for document readers
MarkdownReaderTests.csTests specific to MarkdownReader functionality
MarkItDownReaderTests.csTests specific to MarkItDownReader with CLI availability checks
ArrayUtils.csTest utility for mapping 2D arrays used in table assertions
Microsoft.Extensions.DataIngestion.Tests.csprojUpdated project file adding references and test file configuration
General.propsAdds Markdig package reference
Versions.propsSpecifies Markdig version 0.42.0

@ericstjericstj requested a review fromCopilotOctober 30, 2025 01:15
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

Copilot reviewed 13 out of 20 changed files in this pull request and generated 3 comments.

# Conflicts:#test/Libraries/Microsoft.Extensions.DataIngestion.Tests/Microsoft.Extensions.DataIngestion.Tests.csproj
- delete temporary file when .CopyToAsync fails- handle all image types
This was referencedNov 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stephentoubstephentoubstephentoub left review comments

Copilot code reviewCopilotCopilot left review comments

@cincuranetcincuranetcincuranet approved these changes

@rojirojiAwaiting requested review from roji

@ericstjericstjAwaiting requested review from ericstj

Assignees

@adamsitnikadamsitnik

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adamsitnik@roji@stephentoub@cincuranet@ericstj
[8]ページ先頭
©2009-2025 Movatter.jp