- Notifications
You must be signed in to change notification settings - Fork18.8k
vendor: github.com/moby/buildkit v0.20.0#49495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
full diff:moby/buildkit@v0.20.0-rc3...v0.20.0Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Timeout: c.Timeout, | ||
Client: tracing.DefaultClient, | ||
Timeout: c.Timeout, | ||
UserAgent: bkversion.UserAgent(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Saw the user agent was added; does the user agent and/or should it be matching "docker engine" or "buildkit"?@jsternberg@tonistiigi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is the same user-agent used for registry requests andADD
. The value is configurable by the importer (but unrelated to this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, thanks; wasn't sure if it's something we had do wire up to pass through our user-agent.
(but perhaps something for a future release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
af898ab
intomoby:masterUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
full diff:moby/buildkit@v0.20.0-rc3...v0.20.0
Signed-off-by: Paweł Gronowskipawel.gronowski@docker.com