- Notifications
You must be signed in to change notification settings - Fork2.1k
[27.x backport] run: fix GetList return empty issue for throttledevice#5339
Merged
vvoland merged 1 commit intodocker:27.xfromAug 12, 2024
Merged
Conversation
Test "--device-read-bps" "--device-write-bps" will fail. The rootcause is that GetList helper return empty as its local variableinitialized to zero size.This patch fix it by setting the related slice size to non-zero.Signed-off-by: Jianyong Wu <wujianyong@hygon.cn>Fixes:docker#5321(cherry picked from commit73e78a5)Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
codecov-commenter commentedAug 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## 27.x #5339 +/- ##==========================================- Coverage 61.49% 61.49% -0.01%========================================== Files 299 299 Lines 20869 20867 -2 ==========================================- Hits 12834 12832 -2 Misses 7120 7120 Partials 915 915 |
vvoland approved these changesAug 12, 2024
renovatebot added a commit to earthly/dind that referenced this pull requestAug 19, 2024
[](https://renovatebot.com)This PR contains the following updates:| Package | Update | Change ||---|---|---|| [docker/docker](https://togithub.com/docker/docker) | patch | `27.1.1`-> `27.1.2` |---### Release Notes<details><summary>docker/docker (docker/docker)</summary>### [`v27.1.2`](https://togithub.com/moby/moby/releases/tag/v27.1.2)[CompareSource](https://togithub.com/docker/docker/compare/v27.1.1...v27.1.2)#### 27.1.2For a full list of pull requests and changes in this release, refer tothe relevant GitHub milestones:- [docker/cli, 27.1.2milestone](https://togithub.com/docker/cli/issues?q=is%3Aclosed+milestone%3A27.1.2)- [moby/moby, 27.1.2milestone](https://togithub.com/moby/moby/issues?q=is%3Aclosed+milestone%3A27.1.2)- Deprecated and removed features, see [DeprecatedFeatures](https://togithub.com/docker/cli/blob/v27.1.2/docs/deprecated.md).- Changes to the Engine API, see [API versionhistory](https://togithub.com/moby/moby/blob/v27.1.2/docs/api/version-history.md).##### Bug fixes and enhancements- Fix a regression that could result in a `ResourceExhausted desc =grpc: received message larger than max` error when building from a largeDockerfile. [moby/moby#48245](https://togithub.com/moby/moby/pull/48245)- CLI: Fix `docker attach` printing a spurious `context cancelled` errormessage. [docker/cli#5296](https://togithub.com/docker/cli/pull/5296)- CLI: Fix `docker attach` exiting on `SIGINT` instead of forwarding thesignal to the container and waiting for it to exit.[docker/cli#5302](https://togithub.com/docker/cli/pull/5302)- CLI: Fix `--device-read-bps` and `--device-write-bps` options nottaking effect.[docker/cli#5339](https://togithub.com/docker/cli/pull/5339)- CLI: Fix a panic happening in some cases while running a plugin.[docker/cli#5337](https://togithub.com/docker/cli/pull/5337)##### Packaging updates- Update BuildKit to[v0.15.1](https://togithub.com/moby/buildkit/releases/tag/v0.15.1).[moby/moby#48246](https://togithub.com/moby/moby/pull/48246)- Update Buildx to[v0.16.2](https://togithub.com/docker/buildx/releases/tag/v0.16.2).[docker/docker-ce-packaging#1043](https://togithub.com/docker/docker-ce-packaging/pull/1043)- Update Go runtime to 1.21.13.[moby/moby#48301](https://togithub.com/moby/moby/pull/48301),[docker/cli#5325](https://togithub.com/docker/cli/pull/5325),[docker/docker-ce-packaging#1046](https://togithub.com/docker/docker-ce-packaging/pull/1046)- Remove unused `docker-proxy.exe` binary from Windows packages.[docker/docker-ce-packaging#1045](https://togithub.com/docker/docker-ce-packaging/pull/1045)</details>---### Configuration📅 **Schedule**: Branch creation - "after 6am on monday" (UTC), Automerge- At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). View the[repository job log](https://developer.mend.io/github/earthly/dind).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
renovatebot added a commit to earthly/dind that referenced this pull requestAug 19, 2024
[](https://renovatebot.com)This PR contains the following updates:| Package | Update | Change ||---|---|---|| [docker/docker](https://togithub.com/docker/docker) | patch | `27.1.1`-> `27.1.2` |---### Release Notes<details><summary>docker/docker (docker/docker)</summary>### [`v27.1.2`](https://togithub.com/moby/moby/releases/tag/v27.1.2)[CompareSource](https://togithub.com/docker/docker/compare/v27.1.1...v27.1.2)#### 27.1.2For a full list of pull requests and changes in this release, refer tothe relevant GitHub milestones:- [docker/cli, 27.1.2milestone](https://togithub.com/docker/cli/issues?q=is%3Aclosed+milestone%3A27.1.2)- [moby/moby, 27.1.2milestone](https://togithub.com/moby/moby/issues?q=is%3Aclosed+milestone%3A27.1.2)- Deprecated and removed features, see [DeprecatedFeatures](https://togithub.com/docker/cli/blob/v27.1.2/docs/deprecated.md).- Changes to the Engine API, see [API versionhistory](https://togithub.com/moby/moby/blob/v27.1.2/docs/api/version-history.md).##### Bug fixes and enhancements- Fix a regression that could result in a `ResourceExhausted desc =grpc: received message larger than max` error when building from a largeDockerfile. [moby/moby#48245](https://togithub.com/moby/moby/pull/48245)- CLI: Fix `docker attach` printing a spurious `context cancelled` errormessage. [docker/cli#5296](https://togithub.com/docker/cli/pull/5296)- CLI: Fix `docker attach` exiting on `SIGINT` instead of forwarding thesignal to the container and waiting for it to exit.[docker/cli#5302](https://togithub.com/docker/cli/pull/5302)- CLI: Fix `--device-read-bps` and `--device-write-bps` options nottaking effect.[docker/cli#5339](https://togithub.com/docker/cli/pull/5339)- CLI: Fix a panic happening in some cases while running a plugin.[docker/cli#5337](https://togithub.com/docker/cli/pull/5337)##### Packaging updates- Update BuildKit to[v0.15.1](https://togithub.com/moby/buildkit/releases/tag/v0.15.1).[moby/moby#48246](https://togithub.com/moby/moby/pull/48246)- Update Buildx to[v0.16.2](https://togithub.com/docker/buildx/releases/tag/v0.16.2).[docker/docker-ce-packaging#1043](https://togithub.com/docker/docker-ce-packaging/pull/1043)- Update Go runtime to 1.21.13.[moby/moby#48301](https://togithub.com/moby/moby/pull/48301),[docker/cli#5325](https://togithub.com/docker/cli/pull/5325),[docker/docker-ce-packaging#1046](https://togithub.com/docker/docker-ce-packaging/pull/1046)- Remove unused `docker-proxy.exe` binary from Windows packages.[docker/docker-ce-packaging#1045](https://togithub.com/docker/docker-ce-packaging/pull/1045)</details>---### Configuration📅 **Schedule**: Branch creation - "after 6am on monday" (UTC), Automerge- At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). View the[repository job log](https://developer.mend.io/github/earthly/dind).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test "--device-read-bps" "--device-write-bps" will fail. The root cause is that GetList helper return empty as its local variable initialized to zero size.
This patch fix it by setting the related slice size to non-zero.
(cherry picked from commit73e78a5)
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)