Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add rolldown-vite support#128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sapphi-red
Copy link
Contributor

While this plugin mostly works withrolldown-vite, there are a few areas where it could leverage Rolldown's built-in features to improve performance.

This PR includes the following changes:

  • Usebuild.rollupOptions.inject for rolldown-vite: this avoids the extra parsing step by@rollup/plugin-inject and can improve perf.
  • Use thebanner hook of a Rollup plugin foroptimizeDeps.rollupOptions instead of thebanner option inoptimizeDeps.esbuildOptions: most options inoptimizeDeps.esbuildOptions are mapped tooptimizeDeps.rollupOptions, butbanner is not due to incompatibility.
  • Add CI to ensure rolldown-vite support

I tested this withhttps://github.com/owncloud/web1 and it reduced the build time ~3.5s (~25%).

closevitejs/rolldown-vite#133

Footnotes

  1. I used sass-embedded instead of sass locally↩

MrZipper7, J3m5, beaussan, rinodrummer, TheAlexLichter, and reslear reacted with hooray emoji
@davidmyersdev
Copy link
Owner

@sapphi-red I fixed an issue with the PNPM install on CI, but it looks like the new workflow is failing for another reason now. Mind taking a look at that?

sapphi-red reacted with thumbs up emoji

@sapphi-red
Copy link
ContributorAuthor

@davidmyersdev
Thanks! The error was caused by the node version (Vite 7 requires 20.19+, 22.10+). I've pushed a commit to update the node version in CI.

@davidmyersdev
Copy link
Owner

That did it! Thank you!

@davidmyersdevdavidmyersdev merged commitca49ba3 intodavidmyersdev:mainJul 6, 2025
5 checks passed
@davidmyersdev
Copy link
Owner

Released inv0.24.0.

sapphi-red, beaussan, and taskylizard reacted with rocket emoji

@sapphi-redsapphi-red deleted the add-rolldown-vite-support branchJuly 7, 2025 08:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugin-node-polyfills wrapper

2 participants

@sapphi-red@davidmyersdev
[8]ページ先頭
©2009-2025 Movatter.jp