NotificationsYou must be signed in to change notification settings
Fork929
Star10.2k

chore: add cherry-picks for patch 2.18.2#16061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

stirby merged 3 commits intorelease/2.18frompatch/2.18.2

Jan 7, 2025

Merged

chore: add cherry-picks for patch 2.18.2#16061

stirby merged 3 commits intorelease/2.18frompatch/2.18.2

Jan 7, 2025

Conversation

Copy link

Collaborator

stirby commentedJan 7, 2025

No description provided.

johnstcnand others added3 commits

January 2, 2025 18:46

fix(coderd/wsbuilder): correctly evaluate dynamic workspace tag values (

38f471a

#15897)Relates to#15894:- Adds `coderdenttest.NewExternalProvisionerDaemonTerraform`- Adds integration-style test coverage for creating a workspace with`coder_workspace_tags` specified in `main.tf`- Modifies `coderd/wsbuilder` to fetch template version variables and  includes them in eval context for evaluating `coder_workspace_tags`(cherry picked from commitdcf5153)(cherry picked from commit01f1c94)

feat: allow entering non-default values in multi-select (#15935)

e6db64f

(cherry picked from commit638247c)

fix(provisioner/terraform/tfparse): skip evaluation of unrelated para…

5e71a54

…meters (#16023) (#16035)* Improves tfparse test coverage to include more parameter types andvalues* Adds tests with unrelated parameters that should be ignored by tfparse* Modifies tfparse to only attempt evaluation of parameters referencedby coder_workspace_tags(cherry picked from commit1ab10cf)Co-authored-by: Cian Johnston <cian@coder.com>