- Notifications
You must be signed in to change notification settings - Fork240
ref: Tidy up types and remove string coercion#1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedAug 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1536 +/- ##==========================================+ Coverage 91.66% 92.92% +1.25%========================================== Files 5 5 Lines 324 325 +1 Branches 86 77 -9 ==========================================+ Hits 297 302 +5+ Misses 27 21 -6- Partials 0 2 +2
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/buildExec.ts Outdated
| ['pull_request','pull_request_target'].every( | ||
| (event)=>event!==context.eventName, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ['pull_request','pull_request_target'].every( | |
| (event)=>event!==context.eventName, | |
| ) | |
| !['pull_request','pull_request_target'].includes(context.eventName) |
similar to below
nicholas-codecovAug 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ahhh yea that would be better ... i spent a hot minute looking at MDN docs trying to figure out the "smart" way ... and all i needed was a! 🤦
This PR adds in a package to give the correct types for GH payload events, as well this PR removes redundant string coercion that's not needed.