Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork705
feat: use chaijs/loupe for inspection#1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
I think we'd likehttps://github.com/chaijs/loupe to display |
I think this one is a good change, please comment if you disagree |
In both of these instances the changes are welcome I think. |
Alright, thanks for the confirmation. For the next ones, I suggest you just add an emoji on the github comment to say that you're OK with the change or add a new comment if you're not. |
Using ISO format for printing dates: |
Unquoted complex key in objects: |
We'll need to fixchaijs/loupe#44 as well |
A bit more complex: when using prototype properties, Object.create({tea:'chai'}) We use to show it as regular properties: We now exclude them which makes it less readable: What do you think? |
|
Typed array: |
I think this is a regression. Ideally loupe would give us inspections which are syntactically valid and can be pasted into a REPL with minimal editing. I think loupe should detect if it needs quotes and add them. |
This looks like a regression. I'd expect |
This is intentional. It is useful to know what typed array class is being inspected. We should update chai here. |
Another one: it('inspect with custom stylize-calling inspect()s',function(){chai.use(function(_chai,_){varobj={outer:{inspect:function(depth,options){returnoptions.stylize('Object content','string');}}};expect(_.inspect(obj)).to.equal('{ outer: Object content }');});}); |
What does nodejs do here? To me the loupe example seems correct but I’d be interested in Nodes output as it has the same API |
For referencethis is Node's API. So the test is correct and I should fix the code. |
To make progress on this, I would now need some reviews on loupe pull requests.@keithamus can you take a look please?https://github.com/chaijs/loupe/pulls |
All fixes on loupe and been merged and published to npm. This should be able to progress now. |
@pcorpet I've also invited you to the chai org as a maintainer for loupe! |
Thanks for the review, this PR should now be good for review as the tests pass. |
keithamus approved these changesJun 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This LGTM but perhaps a second set of eyes would be good.@flaambe as you worked on this before, do you think this looks good?
| }, "expected { tea: \'chai\'} to deeply equal { tea: \'black\'}"); | ||
| }, "expected {} to deeply equal {}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I feel like we're losing data here. Perhaps this should be a feature of loupe that if the object has no own-properties then it can inspect the prototype to make it more useful for instances like this?
| message:'expected [Array(4) ] to equal [Array(4) ]' | ||
| message:"expected ['string1', 'string2', …(2) ] to equal ['string5', 'string6', …(2) ]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is so much nicer IMO 👌
flaambe approved these changesJun 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but I was thinking we are going to replacelib/chai/utils/inspect.js completely?
I agree that's definitely the ultimate goal here. Merging this PR gets us a lot closer to that though so I'm happy to ship this. |
@pcorpet did you want to try porting this PR to the |
pcorpet added a commit to pcorpet/chai that referenced this pull requestJul 5, 2021
keithamus pushed a commit that referenced this pull requestJul 8, 2021
keithamus added a commit that referenced this pull requestFeb 7, 2023
* Fixed a regression that caused SyntaxErrors on IE 11The changes made in#1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai.* chai@4.3.2* export chai.Assertion (#1378)* chai@4.3.3* fix: support inspecting bigints (#1321) (#1383)* 4.3.4* feat: use chaijs/loupe for inspection (#1401) (#1407)Fix#1228* fix: package.json - deprecation warning on exports field (#1400)* fix package.json exports* build(deps-dev): bump codecov from 3.1.0 to 3.7.1 (#1446)Bumps [codecov](https://github.com/codecov/codecov-node) from 3.1.0 to 3.7.1.- [Release notes](https://github.com/codecov/codecov-node/releases)- [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md)- [Commits](codecov/codecov-node@v3.1.0...v3.7.1)---updated-dependencies:- dependency-name: codecov dependency-type: direct:development...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* build chaijs* 4.3.5* fix: use loupe@^2.3.1* build chaijs* 4.3.6* fix: deep-eql bump package to support symbols comparison (#1483)* 4.3.7* build* chore: 4.x.x: Fix link to commit logs on GitHub (#1487)* 4.x.x: Fix link to commit logs on GitHubAs there is no `master` branch, the link returned a 404.* Update History.mdCo-authored-by: Andre Meyering <info@andremeyering.de>Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>* build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (#1488)Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.- [Release notes](https://github.com/socketio/socket.io-parser/releases)- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)---updated-dependencies:- dependency-name: socket.io-parser dependency-type: indirect...Signed-off-by: dependabot[bot] <support@github.com>Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* test: fix typo in test.js (#1459)* docs: specify return type of objDisplay (#1490)previously it was incorrectly labeled as `objDisplay(obj: object): void` in `@types/chai`.* feat: rework into ES modulesThis moves all of the sources to be ES modules rather than CommonJS.In order to produce the entrypoints, we use esbuild as a bundler (and asa transpiler in a way).Due to the fact that some dependencies are written in CommonJS, weactually use esbuild to create _two_ bundles: a CommonJS bundle, and anES module bundle.Otherwise, someone importing the raw source would inevitably end uptrying to import a CommonJS module somewhere down the tree, which wouldnot work in browsers natively.---------Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: Lee Newson <lnewso@hotmail.com>Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>Co-authored-by: rbruckheimer <rob@cosaic.io>Co-authored-by: Mike Frysinger <vapier@gmail.com>Co-authored-by: Pascal Corpet <pcorpet@users.noreply.github.com>Co-authored-by: Mimi <stevenjoezhang@gmail.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Scott Newcomer <snewcomer@users.noreply.github.com>Co-authored-by: Andre Meyering <info@andremeyering.de>Co-authored-by: Mavaddat Javid <5055400+mavaddat@users.noreply.github.com>Co-authored-by: scarf <greenscarf005@gmail.com>Co-authored-by: James Garbutt <james.garbutt@crispthinking.com>
renovatebot referenced this pull request in runtime-env/import-meta-envJul 7, 2024
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai))| [`4.4.1` ->`5.1.1`](https://renovatebot.com/diffs/npm/chai/4.4.1/5.1.1) |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>chaijs/chai (chai)</summary>### [`v5.1.1`](https://togithub.com/chaijs/chai/releases/tag/v5.1.1)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.1.0...v5.1.1)#### What's Changed- Set up ESLint for JSDoc comments by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1605](https://togithub.com/chaijs/chai/pull/1605)- build(deps-dev): bump ip from 1.1.8 to 1.1.9 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/chaijs/chai/pull/1608](https://togithub.com/chaijs/chai/pull/1608)- Correct Mocha import instructions by[@​MattiSG](https://togithub.com/MattiSG) in[https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611)- fix: support some virtual contexts in `toThrow` by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1609](https://togithub.com/chaijs/chai/pull/1609)#### New Contributors- [@​MattiSG](https://togithub.com/MattiSG) made their firstcontribution in[https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611)**Full Changelog**:chaijs/chai@v5.1.0...v5.1.1### [`v5.1.0`](https://togithub.com/chaijs/chai/releases/tag/v5.1.0)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.0.3...v5.1.0)#### What's Changed- Remove useless guards and add parentheses to constuctors by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1593](https://togithub.com/chaijs/chai/pull/1593)- Cleanup jsdoc comments by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1596](https://togithub.com/chaijs/chai/pull/1596)- Convert comments in "legal comments" format to jsdoc or normalcomments by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1598](https://togithub.com/chaijs/chai/pull/1598)- Implement `iterable` assertion by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1592](https://togithub.com/chaijs/chai/pull/1592)- Assert interface fix by[@​developer-bandi](https://togithub.com/developer-bandi) in[https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601)- Set support in same members by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1583](https://togithub.com/chaijs/chai/pull/1583)- Fix publish script by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1602](https://togithub.com/chaijs/chai/pull/1602)#### New Contributors- [@​developer-bandi](https://togithub.com/developer-bandi) madetheir first contribution in[https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601)**Full Changelog**:chaijs/chai@v5.0.3...v5.1.0### [`v5.0.3`](https://togithub.com/chaijs/chai/releases/tag/v5.0.3)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.0.2...v5.0.3)Fix bad v5.0.2 publish.**Full Changelog**:chaijs/chai@v5.0.2...v5.0.3### [`v5.0.2`](https://togithub.com/chaijs/chai/releases/tag/v5.0.2)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.0.0...v5.0.2)#### What's Changed- build(deps): bump nanoid and mocha by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/chaijs/chai/pull/1558](https://togithub.com/chaijs/chai/pull/1558)- remove `bump-cli` by [@​koddsson](https://togithub.com/koddsson)in[https://github.com/chaijs/chai/pull/1559](https://togithub.com/chaijs/chai/pull/1559)- Update developer dependencies by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1560](https://togithub.com/chaijs/chai/pull/1560)- fix: removes `??` for node compat (5.x) by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1576](https://togithub.com/chaijs/chai/pull/1576)- Update `loupe` to latest version by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1579](https://togithub.com/chaijs/chai/pull/1579)- Re-enable some webkit tests by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1580](https://togithub.com/chaijs/chai/pull/1580)- Remove a bunch of if statements in test/should.js by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1581](https://togithub.com/chaijs/chai/pull/1581)- Remove a bunch of unused files by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1582](https://togithub.com/chaijs/chai/pull/1582)- Fix 1564 by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1566](https://togithub.com/chaijs/chai/pull/1566)**Full Changelog**:chaijs/chai@v5.0.1...v5.0.2### [`v5.0.0`](https://togithub.com/chaijs/chai/releases/tag/v5.0.0)[CompareSource](https://togithub.com/chaijs/chai/compare/v4.4.1...v5.0.0)#### BREAKING CHANGES- Chai now only supports EcmaScript Modules (ESM). This means your testswill need to either have `import {...} from 'chai'` or `import('chai')`.`require('chai')` will cause failures in nodejs. If you're using ESM andseeing failures, it may be due to a bundler or transpiler which isincorrectly converting import statements into require calls.- Dropped support for Internet Explorer.- Dropped support for NodeJS < 18.- Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome100, Edge 100. Support for browsers prior to these versions is "besteffort" (bug reports on older browsers will be assessed individually andmay be marked as wontfix).#### What's Changed- feat: use chaijs/loupe for inspection by[@​pcorpet](https://togithub.com/pcorpet) in[https://github.com/chaijs/chai/pull/1401](https://togithub.com/chaijs/chai/pull/1401)- docs: fix URL in README by [@​Izzur](https://togithub.com/Izzur)in[https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413)- Remove `get-func-name` dependency by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1416](https://togithub.com/chaijs/chai/pull/1416)- Convert Makefile script to npm scripts by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1424](https://togithub.com/chaijs/chai/pull/1424)- Clean up README badges by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1422](https://togithub.com/chaijs/chai/pull/1422)- fix: package.json - deprecation warning on exports field by[@​stevenjoezhang](https://togithub.com/stevenjoezhang) in[https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400)- fix: deep-eql bump package to support symbols by[@​snewcomer](https://togithub.com/snewcomer) in[https://github.com/chaijs/chai/pull/1458](https://togithub.com/chaijs/chai/pull/1458)- ES module conversion PoC by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498)- chore: drop commonjs support by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1503](https://togithub.com/chaijs/chai/pull/1503)- Update pathval by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1527](https://togithub.com/chaijs/chai/pull/1527)- Update check-error by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1528](https://togithub.com/chaijs/chai/pull/1528)- update `deep-eql` to latest version by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1542](https://togithub.com/chaijs/chai/pull/1542)- Inline `type-detect` as a simple function by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1544](https://togithub.com/chaijs/chai/pull/1544)- Update loupe by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1545](https://togithub.com/chaijs/chai/pull/1545)- Typo 'Test an object' not 'Test and object' by[@​mavaddat](https://togithub.com/mavaddat) in[https://github.com/chaijs/chai/pull/1460](https://togithub.com/chaijs/chai/pull/1460)- Update `assertion-error` to it's latest major version! by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1543](https://togithub.com/chaijs/chai/pull/1543)- Replacing Karma with Web Test Runner by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1546](https://togithub.com/chaijs/chai/pull/1546)#### New Contributors- [@​Izzur](https://togithub.com/Izzur) made their firstcontribution in[https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413)- [@​stevenjoezhang](https://togithub.com/stevenjoezhang) madetheir first contribution in[https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400)- [@​43081j](https://togithub.com/43081j) made their firstcontribution in[https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498)**Full Changelog**:chaijs/chai@4.3.1...v5.0.0</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/runtime-env/import-meta-env).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
1 task
solaris007 referenced this pull request in adobe/spacecat-sharedAug 27, 2024
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change | Age | Adoption | Passing |Confidence ||---|---|---|---|---|---|---|---|| [actions/setup-java](https://togithub.com/actions/setup-java) | action| major | `v3` -> `v4` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|| [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai))| devDependencies | major | [`4.5.0` ->`5.1.1`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>actions/setup-java (actions/setup-java)</summary>### [`v4`](https://togithub.com/actions/setup-java/compare/v3...v4)[CompareSource](https://togithub.com/actions/setup-java/compare/v3...v4)</details><details><summary>chaijs/chai (chai)</summary>### [`v5.1.1`](https://togithub.com/chaijs/chai/releases/tag/v5.1.1)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.1.0...v5.1.1)#### What's Changed- Set up ESLint for JSDoc comments by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1605](https://togithub.com/chaijs/chai/pull/1605)- build(deps-dev): bump ip from 1.1.8 to 1.1.9 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/chaijs/chai/pull/1608](https://togithub.com/chaijs/chai/pull/1608)- Correct Mocha import instructions by[@​MattiSG](https://togithub.com/MattiSG) in[https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611)- fix: support some virtual contexts in `toThrow` by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1609](https://togithub.com/chaijs/chai/pull/1609)#### New Contributors- [@​MattiSG](https://togithub.com/MattiSG) made their firstcontribution in[https://github.com/chaijs/chai/pull/1611](https://togithub.com/chaijs/chai/pull/1611)**Full Changelog**:chaijs/chai@v5.1.0...v5.1.1### [`v5.1.0`](https://togithub.com/chaijs/chai/releases/tag/v5.1.0)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.0.3...v5.1.0)#### What's Changed- Remove useless guards and add parentheses to constuctors by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1593](https://togithub.com/chaijs/chai/pull/1593)- Cleanup jsdoc comments by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1596](https://togithub.com/chaijs/chai/pull/1596)- Convert comments in "legal comments" format to jsdoc or normalcomments by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1598](https://togithub.com/chaijs/chai/pull/1598)- Implement `iterable` assertion by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1592](https://togithub.com/chaijs/chai/pull/1592)- Assert interface fix by[@​developer-bandi](https://togithub.com/developer-bandi) in[https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601)- Set support in same members by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1583](https://togithub.com/chaijs/chai/pull/1583)- Fix publish script by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1602](https://togithub.com/chaijs/chai/pull/1602)#### New Contributors- [@​developer-bandi](https://togithub.com/developer-bandi) madetheir first contribution in[https://github.com/chaijs/chai/pull/1601](https://togithub.com/chaijs/chai/pull/1601)**Full Changelog**:chaijs/chai@v5.0.3...v5.1.0### [`v5.0.3`](https://togithub.com/chaijs/chai/releases/tag/v5.0.3)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.0.2...v5.0.3)Fix bad v5.0.2 publish.**Full Changelog**:chaijs/chai@v5.0.2...v5.0.3### [`v5.0.2`](https://togithub.com/chaijs/chai/releases/tag/v5.0.2)[CompareSource](https://togithub.com/chaijs/chai/compare/v5.0.0...v5.0.2)#### What's Changed- build(deps): bump nanoid and mocha by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/chaijs/chai/pull/1558](https://togithub.com/chaijs/chai/pull/1558)- remove `bump-cli` by [@​koddsson](https://togithub.com/koddsson)in[https://github.com/chaijs/chai/pull/1559](https://togithub.com/chaijs/chai/pull/1559)- Update developer dependencies by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1560](https://togithub.com/chaijs/chai/pull/1560)- fix: removes `??` for node compat (5.x) by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1576](https://togithub.com/chaijs/chai/pull/1576)- Update `loupe` to latest version by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1579](https://togithub.com/chaijs/chai/pull/1579)- Re-enable some webkit tests by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1580](https://togithub.com/chaijs/chai/pull/1580)- Remove a bunch of if statements in test/should.js by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1581](https://togithub.com/chaijs/chai/pull/1581)- Remove a bunch of unused files by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1582](https://togithub.com/chaijs/chai/pull/1582)- Fix 1564 by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1566](https://togithub.com/chaijs/chai/pull/1566)**Full Changelog**:chaijs/chai@v5.0.1...v5.0.2### [`v5.0.0`](https://togithub.com/chaijs/chai/releases/tag/v5.0.0)[CompareSource](https://togithub.com/chaijs/chai/compare/v4.5.0...v5.0.0)#### BREAKING CHANGES- Chai now only supports EcmaScript Modules (ESM). This means your testswill need to either have `import {...} from 'chai'` or `import('chai')`.`require('chai')` will cause failures in nodejs. If you're using ESM andseeing failures, it may be due to a bundler or transpiler which isincorrectly converting import statements into require calls.- Dropped support for Internet Explorer.- Dropped support for NodeJS < 18.- Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome100, Edge 100. Support for browsers prior to these versions is "besteffort" (bug reports on older browsers will be assessed individually andmay be marked as wontfix).#### What's Changed- feat: use chaijs/loupe for inspection by[@​pcorpet](https://togithub.com/pcorpet) in[https://github.com/chaijs/chai/pull/1401](https://togithub.com/chaijs/chai/pull/1401)- docs: fix URL in README by [@​Izzur](https://togithub.com/Izzur)in[https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413)- Remove `get-func-name` dependency by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1416](https://togithub.com/chaijs/chai/pull/1416)- Convert Makefile script to npm scripts by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1424](https://togithub.com/chaijs/chai/pull/1424)- Clean up README badges by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1422](https://togithub.com/chaijs/chai/pull/1422)- fix: package.json - deprecation warning on exports field by[@​stevenjoezhang](https://togithub.com/stevenjoezhang) in[https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400)- fix: deep-eql bump package to support symbols by[@​snewcomer](https://togithub.com/snewcomer) in[https://github.com/chaijs/chai/pull/1458](https://togithub.com/chaijs/chai/pull/1458)- ES module conversion PoC by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498)- chore: drop commonjs support by[@​43081j](https://togithub.com/43081j) in[https://github.com/chaijs/chai/pull/1503](https://togithub.com/chaijs/chai/pull/1503)- Update pathval by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1527](https://togithub.com/chaijs/chai/pull/1527)- Update check-error by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1528](https://togithub.com/chaijs/chai/pull/1528)- update `deep-eql` to latest version by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1542](https://togithub.com/chaijs/chai/pull/1542)- Inline `type-detect` as a simple function by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1544](https://togithub.com/chaijs/chai/pull/1544)- Update loupe by [@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1545](https://togithub.com/chaijs/chai/pull/1545)- Typo 'Test an object' not 'Test and object' by[@​mavaddat](https://togithub.com/mavaddat) in[https://github.com/chaijs/chai/pull/1460](https://togithub.com/chaijs/chai/pull/1460)- Update `assertion-error` to it's latest major version! by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1543](https://togithub.com/chaijs/chai/pull/1543)- Replacing Karma with Web Test Runner by[@​koddsson](https://togithub.com/koddsson) in[https://github.com/chaijs/chai/pull/1546](https://togithub.com/chaijs/chai/pull/1546)#### New Contributors- [@​Izzur](https://togithub.com/Izzur) made their firstcontribution in[https://github.com/chaijs/chai/pull/1413](https://togithub.com/chaijs/chai/pull/1413)- [@​stevenjoezhang](https://togithub.com/stevenjoezhang) madetheir first contribution in[https://github.com/chaijs/chai/pull/1400](https://togithub.com/chaijs/chai/pull/1400)- [@​43081j](https://togithub.com/43081j) made their firstcontribution in[https://github.com/chaijs/chai/pull/1498](https://togithub.com/chaijs/chai/pull/1498)**Full Changelog**:chaijs/chai@4.3.1...v5.0.0</details>---### Configuration📅 **Schedule**: Branch creation - "after 2pm on Monday" in timezoneEurope/Zurich, Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get[config help](https://togithub.com/renovatebot/renovate/discussions) ifthat's undesired.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). View the[repository joblog](https://developer.mend.io/github/adobe/spacecat-shared).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>Co-authored-by: Dominique Jäggi <1872195+solaris007@users.noreply.github.com>
This was referencedSep 10, 2024
This was referencedSep 12, 2024
renovatebot referenced this pull request in davidsneighbour/hugo-modulesSep 14, 2024
This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [chai](http://chaijs.com)([source](https://redirect.github.com/chaijs/chai)) | [`^4.5.0` ->`^5.0.0`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>chaijs/chai (chai)</summary>###[`v5.1.1`](https://redirect.github.com/chaijs/chai/releases/tag/v5.1.1)[CompareSource](https://redirect.github.com/chaijs/chai/compare/v5.1.0...v5.1.1)#### What's Changed- Set up ESLint for JSDoc comments by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1605](https://redirect.github.com/chaijs/chai/pull/1605)- build(deps-dev): bump ip from 1.1.8 to 1.1.9 by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/chaijs/chai/pull/1608](https://redirect.github.com/chaijs/chai/pull/1608)- Correct Mocha import instructions by[@​MattiSG](https://redirect.github.com/MattiSG) in[https://github.com/chaijs/chai/pull/1611](https://redirect.github.com/chaijs/chai/pull/1611)- fix: support some virtual contexts in `toThrow` by[@​43081j](https://redirect.github.com/43081j) in[https://github.com/chaijs/chai/pull/1609](https://redirect.github.com/chaijs/chai/pull/1609)#### New Contributors- [@​MattiSG](https://redirect.github.com/MattiSG) made theirfirst contribution in[https://github.com/chaijs/chai/pull/1611](https://redirect.github.com/chaijs/chai/pull/1611)**Full Changelog**:chaijs/chai@v5.1.0...v5.1.1###[`v5.1.0`](https://redirect.github.com/chaijs/chai/releases/tag/v5.1.0)[CompareSource](https://redirect.github.com/chaijs/chai/compare/v5.0.3...v5.1.0)#### What's Changed- Remove useless guards and add parentheses to constuctors by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1593](https://redirect.github.com/chaijs/chai/pull/1593)- Cleanup jsdoc comments by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1596](https://redirect.github.com/chaijs/chai/pull/1596)- Convert comments in "legal comments" format to jsdoc or normalcomments by [@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1598](https://redirect.github.com/chaijs/chai/pull/1598)- Implement `iterable` assertion by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1592](https://redirect.github.com/chaijs/chai/pull/1592)- Assert interface fix by[@​developer-bandi](https://redirect.github.com/developer-bandi)in[https://github.com/chaijs/chai/pull/1601](https://redirect.github.com/chaijs/chai/pull/1601)- Set support in same members by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1583](https://redirect.github.com/chaijs/chai/pull/1583)- Fix publish script by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1602](https://redirect.github.com/chaijs/chai/pull/1602)#### New Contributors- [@​developer-bandi](https://redirect.github.com/developer-bandi)made their first contribution in[https://github.com/chaijs/chai/pull/1601](https://redirect.github.com/chaijs/chai/pull/1601)**Full Changelog**:chaijs/chai@v5.0.3...v5.1.0###[`v5.0.3`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.3)[CompareSource](https://redirect.github.com/chaijs/chai/compare/v5.0.2...v5.0.3)Fix bad v5.0.2 publish.**Full Changelog**:chaijs/chai@v5.0.2...v5.0.3###[`v5.0.2`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.2)[CompareSource](https://redirect.github.com/chaijs/chai/compare/v5.0.0...v5.0.2)#### What's Changed- build(deps): bump nanoid and mocha by[@​dependabot](https://redirect.github.com/dependabot) in[https://github.com/chaijs/chai/pull/1558](https://redirect.github.com/chaijs/chai/pull/1558)- remove `bump-cli` by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1559](https://redirect.github.com/chaijs/chai/pull/1559)- Update developer dependencies by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1560](https://redirect.github.com/chaijs/chai/pull/1560)- fix: removes `??` for node compat (5.x) by[@​43081j](https://redirect.github.com/43081j) in[https://github.com/chaijs/chai/pull/1576](https://redirect.github.com/chaijs/chai/pull/1576)- Update `loupe` to latest version by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1579](https://redirect.github.com/chaijs/chai/pull/1579)- Re-enable some webkit tests by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1580](https://redirect.github.com/chaijs/chai/pull/1580)- Remove a bunch of if statements in test/should.js by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1581](https://redirect.github.com/chaijs/chai/pull/1581)- Remove a bunch of unused files by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1582](https://redirect.github.com/chaijs/chai/pull/1582)- Fix 1564 by [@​koddsson](https://redirect.github.com/koddsson)in[https://github.com/chaijs/chai/pull/1566](https://redirect.github.com/chaijs/chai/pull/1566)**Full Changelog**:chaijs/chai@v5.0.1...v5.0.2###[`v5.0.0`](https://redirect.github.com/chaijs/chai/releases/tag/v5.0.0)[CompareSource](https://redirect.github.com/chaijs/chai/compare/v4.5.0...v5.0.0)#### BREAKING CHANGES- Chai now only supports EcmaScript Modules (ESM). This means your testswill need to either have `import {...} from 'chai'` or `import('chai')`.`require('chai')` will cause failures in nodejs. If you're using ESM andseeing failures, it may be due to a bundler or transpiler which isincorrectly converting import statements into require calls.- Dropped support for Internet Explorer.- Dropped support for NodeJS < 18.- Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome100, Edge 100. Support for browsers prior to these versions is "besteffort" (bug reports on older browsers will be assessed individually andmay be marked as wontfix).#### What's Changed- feat: use chaijs/loupe for inspection by[@​pcorpet](https://redirect.github.com/pcorpet) in[https://github.com/chaijs/chai/pull/1401](https://redirect.github.com/chaijs/chai/pull/1401)- docs: fix URL in README by[@​Izzur](https://redirect.github.com/Izzur) in[https://github.com/chaijs/chai/pull/1413](https://redirect.github.com/chaijs/chai/pull/1413)- Remove `get-func-name` dependency by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1416](https://redirect.github.com/chaijs/chai/pull/1416)- Convert Makefile script to npm scripts by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1424](https://redirect.github.com/chaijs/chai/pull/1424)- Clean up README badges by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1422](https://redirect.github.com/chaijs/chai/pull/1422)- fix: package.json - deprecation warning on exports field by[@​stevenjoezhang](https://redirect.github.com/stevenjoezhang) in[https://github.com/chaijs/chai/pull/1400](https://redirect.github.com/chaijs/chai/pull/1400)- fix: deep-eql bump package to support symbols by[@​snewcomer](https://redirect.github.com/snewcomer) in[https://github.com/chaijs/chai/pull/1458](https://redirect.github.com/chaijs/chai/pull/1458)- ES module conversion PoC by[@​43081j](https://redirect.github.com/43081j) in[https://github.com/chaijs/chai/pull/1498](https://redirect.github.com/chaijs/chai/pull/1498)- chore: drop commonjs support by[@​43081j](https://redirect.github.com/43081j) in[https://github.com/chaijs/chai/pull/1503](https://redirect.github.com/chaijs/chai/pull/1503)- Update pathval by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1527](https://redirect.github.com/chaijs/chai/pull/1527)- Update check-error by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1528](https://redirect.github.com/chaijs/chai/pull/1528)- update `deep-eql` to latest version by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1542](https://redirect.github.com/chaijs/chai/pull/1542)- Inline `type-detect` as a simple function by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1544](https://redirect.github.com/chaijs/chai/pull/1544)- Update loupe by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1545](https://redirect.github.com/chaijs/chai/pull/1545)- Typo 'Test an object' not 'Test and object' by[@​mavaddat](https://redirect.github.com/mavaddat) in[https://github.com/chaijs/chai/pull/1460](https://redirect.github.com/chaijs/chai/pull/1460)- Update `assertion-error` to it's latest major version! by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1543](https://redirect.github.com/chaijs/chai/pull/1543)- Replacing Karma with Web Test Runner by[@​koddsson](https://redirect.github.com/koddsson) in[https://github.com/chaijs/chai/pull/1546](https://redirect.github.com/chaijs/chai/pull/1546)#### New Contributors- [@​Izzur](https://redirect.github.com/Izzur) made their firstcontribution in[https://github.com/chaijs/chai/pull/1413](https://redirect.github.com/chaijs/chai/pull/1413)- [@​stevenjoezhang](https://redirect.github.com/stevenjoezhang)made their first contribution in[https://github.com/chaijs/chai/pull/1400](https://redirect.github.com/chaijs/chai/pull/1400)- [@​43081j](https://redirect.github.com/43081j) made their firstcontribution in[https://github.com/chaijs/chai/pull/1498](https://redirect.github.com/chaijs/chai/pull/1498)**Full Changelog**:chaijs/chai@4.3.1...v5.0.0</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR was generated by [Mend Renovate](https://mend.io/renovate/).View the [repository joblog](https://developer.mend.io/github/davidsneighbour/hugo-modules).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referencedNov 1, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#1228
Note that for now this is just a quick attempt to explore which diffs are OK in the error messages and which ones we'd like to fix in
loupebefore merging.