NotificationsYou must be signed in to change notification settings
Fork5.7k
Star43.7k

Fix: always initialize ExportDeclaration attributes#17164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JLHwung merged 8 commits intobabel:mainfromJLHwung:fix-failing-main

Mar 6, 2025

Merged

Fix: always initialize ExportDeclaration attributes#17164

JLHwung merged 8 commits intobabel:mainfromJLHwung:fix-failing-main

Mar 6, 2025

Conversation

Copy link

Contributor

JLHwung commentedMar 6, 2025•
edited
Loading

Q	A
Fixed Issues?	Failing e2e test:https://github.com/babel/babel/actions/runs/13684336191/job/38264467179?pr=17163
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

The CI is failing because recently espree supported the ES2025 import attributes. espree always initializeattributes for the export declaration while Babel only do so when we see thefrom ... source.

I think this is a bug for us since we already handle it in the espree's way for the legacy import assertions, but somehow it is overlooked in import attributes. Here we will initializeattributes property unlessimportAssertions plugin is enabled.

JLHwung added3 commits

March 6, 2025 10:26

chore: bump eslint and espree

15a693b

fix: always initialize ExportDeclaration attributes

2198ddb

update AST fixtures

fd0ce3f

JLHwung added PR: Bug Fix 🐛

A type of pull request used for our changelog categories

PR: Fixes failing main labels

Mar 6, 2025

Copy link

Collaborator

babel-bot commentedMar 6, 2025•
edited
Loading

Build successful! You can test your changes in the REPL here:https://babeljs.io/repl/build/58815

nicolo-ribaudo approved these changes

Mar 6, 2025

View reviewed changes

JLHwung added5 commits

March 6, 2025 11:27

fix: initialize attributes when importAssertions is not enabled

b93dbd4

update AST fixtures

6ff7ddd

update test snapshot

b7b3ded

update Makefile.js

4edd24c

update Babel 8 AST fixtures

f6da260

JLHwung merged commit74f5d6d intobabel:main

Mar 6, 2025

55 checks passed

JLHwung deleted the fix-failing-main branch

March 6, 2025 20:29

laine-hallot pushed a commit to laine-hallot/uwu-parser that referenced this pull request

Mar 31, 2025

Fix: always initialize ExportDeclaration attributes (babel#17164)

0b82113

* chore: bump eslint and espree* fix: always initialize ExportDeclaration attributes* update AST fixtures* fix: initialize attributes when importAssertions is not enabled* update AST fixtures* update test snapshot* update Makefile.js* update Babel 8 AST fixtures