goroutine 11 [running]:testing.tRunner.func1.2({0x5eaae0, 0x7db1f0})/home/cmaglie/Software/go1.22.3/src/testing/testing.go:1631 +0x24atesting.tRunner.func1()/home/cmaglie/Software/go1.22.3/src/testing/testing.go:1634 +0x377panic({0x5eaae0?, 0x7db1f0?})/home/cmaglie/Software/go1.22.3/src/runtime/panic.go:770 +0x132github.com/arduino/pluggable-discovery-protocol-handler/v2.(*Client).Run(0xc0000fa090)/home/cmaglie/Workspace/pluggable-discovery-protocol-handler/client.go:281 +0x16egithub.com/arduino/pluggable-discovery-protocol-handler/v2.TestClient.func1(0xc0000b31e0)/home/cmaglie/Workspace/pluggable-discovery-protocol-handler/client_test.go:108 +0xcctesting.tRunner(0xc0000b31e0, 0x64c850)/home/cmaglie/Software/go1.22.3/src/testing/testing.go:1689 +0xfbcreated by testing.(*T).Run in goroutine 9/home/cmaglie/Software/go1.22.3/src/testing/testing.go:1742 +0x390exit status 2

This PR fixes this problem and cleans up the mutex usage in the library.

Related toarduino/arduino-cli#2665.

cmaglie added4 commits

September 13, 2024 12:25

Removed useless mutex locks

36c5780

Added unit tests

f305b10

Always report errors before closing the channel

0369df2

Otherwise the call to:   msg, err := disc.waitMessage(..)may return both msg and err as nil, breaking the contract.

Rationalized the usage of the disc.lock

cc38790

cmaglie self-assigned this

Sep 13, 2024

cmaglie requested review fromMatteoPologruto,alessio-perugini andumbynos

September 13, 2024 12:46

Copy link

codecov-commenter commentedSep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.79%. Comparing base(c563e77) to head(cc38790).
Report is 4 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@##             main      #50       +/-   ##===========================================+ Coverage   16.84%   32.79%   +15.95%===========================================  Files           4        4                 Lines         374      372        -2     ===========================================+ Hits           63      122       +59+ Misses        294      228       -66- Partials       17       22        +5