- Notifications
You must be signed in to change notification settings - Fork102
detectOfflineLinks is now false per default for all *jar* mojo issue #1258#1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
detectOfflineLinks is now false per default for all *jar* mojo issue #1258#1259
Conversation
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
| /** | ||
| * Detect the links for all modules defined in the project. | ||
| * <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| * If {@code reactorProjects} is defined in a non-aggregator way, it generates default offline links | ||
| * between modules based on the defined project's urls. For instance, if a parent project has two projects | ||
| * <code>module1</code> and <code>module2</code>, the <code>-linkoffline</code> will be: | ||
| * <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
src/main/java/org/apache/maven/plugins/javadoc/JavadocJarMojo.java OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| * <br/> | ||
| * The added Javadoc <code>-linkoffline</code> parameter for <b>module1</b> will be | ||
| * <code>/absolute/path/to/</code><b>module2</b><code>/target/site/apidocs</code> | ||
| * <br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| * @see #offlineLinks | ||
| * @since 2.6 | ||
| */ | ||
| @Parameter(property ="detectOfflineLinks",defaultValue ="false") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why is this here instead of the superclass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
because the role of this change is to have a default offalse for*jar* mojos and leave parent astrue
Signed-off-by: Olivier Lamy <olamy@apache.org>
c8270f9 intoapache:masterUh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Olivier Lamyolamy@apache.org
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
theApache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.