Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add generatedSourcesPath back to the maven project#312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mensinda
Copy link

This is a followup for for#191 to add the generatedSourcesPath back to the maven project paths as the final step of the mojo.

This is analternative implementation to#311.


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Runmvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
theApache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This is a followup for forapache#191 to add the generatedSourcesPath backto the maven project paths as the final step of the mojo.
@oehme
Copy link

LGTM

@slawekjaranowski This fixes the problem I mentioned

@slawekjaranowskislawekjaranowski added the bugSomething isn't working labelMar 13, 2025
@slawekjaranowskislawekjaranowski merged commitd44d1be intoapache:maven-compiler-plugin-3.xMar 14, 2025
88 checks passed
@github-actionsgithub-actionsbot added this to the3.14.1 milestoneMar 14, 2025
@slawekjaranowskislawekjaranowski linked an issueMar 14, 2025 that may beclosed by this pull request
@mensindamensinda deleted the addGeneratedToProjectAgain2 branchMarch 15, 2025 17:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@slawekjaranowskislawekjaranowskislawekjaranowski approved these changes

Labels

bugSomething isn't working

Projects

None yet

Milestone

3.14.1

Development

Successfully merging this pull request may close these issues.

Check last change from #191 against to MCOMPILER-157

3 participants

@mensinda@oehme@slawekjaranowski

[8]ページ先頭

©2009-2025 Movatter.jp