- Notifications
You must be signed in to change notification settings - Fork179
Add generatedSourcesPath back to the maven project#312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
slawekjaranowski merged 1 commit intoapache:maven-compiler-plugin-3.xfrommensinda:addGeneratedToProjectAgain2Mar 14, 2025
Merged
Add generatedSourcesPath back to the maven project#312
slawekjaranowski merged 1 commit intoapache:maven-compiler-plugin-3.xfrommensinda:addGeneratedToProjectAgain2Mar 14, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is a followup for forapache#191 to add the generatedSourcesPath backto the maven project paths as the final step of the mojo.
This was referencedMar 11, 2025
oehme commentedMar 12, 2025
LGTM @slawekjaranowski This fixes the problem I mentioned |
Uh oh!
There was an error while loading.Please reload this page.
slawekjaranowski approved these changesMar 13, 2025
d44d1be
intoapache:maven-compiler-plugin-3.x 88 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup for for#191 to add the generatedSourcesPath back to the maven project paths as the final step of the mojo.
This is analternative implementation to#311.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verify
to make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
theApache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.