- Notifications
You must be signed in to change notification settings - Fork26.8k
fix(core): unregisteronDestroy inResourceImpl whendestroy() is called#61870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…is calledThis commit unregisters the `onDestroy` listener when `destroy()` is called on the `ResourceImpl`. This prevents memory leaks and ensures that the resource reference is not captured in the destroy callback after it has already been destroyed.
thePunderWoman left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
kirjs commentedJun 4, 2025
This PR was merged into the repository by commit080b368. The changes were merged into the following branches: main, 20.0.x |
This issue has been automatically locked due to inactivity. Read more about ourautomatic conversation locking policy. This action has been performed automatically by a bot. |
This commit unregisters the
onDestroylistener whendestroy()is called on theResourceImpl. This prevents memory leaks and ensures that the resource reference is not captured in the destroy callback after it has already been destroyed.