- Notifications
You must be signed in to change notification settings - Fork128
fix: remove ansi characters in steps statusDetails#1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
051bfe8 to6232946Compare
epszaw left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The changes look good. The only one comment I left there is optional to fix
| data: { | ||
| status: getStatusFromError(err as Error), | ||
| stop: Date.now(), | ||
| statusDetails: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can just assigndetails or call the function right in the object:
// ...statusDetails: getMessageAndTraceFromError(err as Error);// ...delatrie commentedAug 1, 2024
That fixes the problem in the following packages, which use
Allure-cypress might still be affected. |
Context
Checklist