Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(allure-jasmine): runtime API, scoping, sequencing, and context propagation of fixtures#1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
baev merged 2 commits intomainfromjasmine-fixtures
Jul 12, 2024

Conversation

@delatrie
Copy link
Collaborator

@delatriedelatrie commentedJul 11, 2024•
edited
Loading

Context

The following issues with fixtures in Jasmine are fixed:

  1. Async hooks are interleaved with each other and with test functions (the sequencing issue).
  2. beforeEach/afterEach hooks affect all tests in the suite instead of only one test (the scoping issue).
  3. Some errors in hooks are not reported properly.
  4. User context doesn't flow into a hook implementation properly.
  5. Unable to use Allure steps in a hook implementation.
  6. Unable to use Allure attachments in a hook implementation.
  7. Unable to rename an Allure fixture.

Extra changes

  • isPromise now is aPromiseLike<T = any> type guard.
  • Add stdout and stderr to Allure Report of allure-jasmine.

Checklist

  - context forwarding  - runtime API  - sequencing  - error reporting  - scoping of beforeEach/afterEach
@delatriedelatrie added the type:bugSomething isn't working labelJul 11, 2024
@github-actionsgithub-actionsbot added theme:apiJavascript API related issue theme:mochaMocha related issue theme:jasmineJasmine related issue labelsJul 11, 2024
@delatriedelatrie marked this pull request as ready for reviewJuly 11, 2024 18:04
@delatriedelatrie changed the titleFix Jasmine fixturesfix(allure-jasmine): runtime API, scoping, sequencing, and context propagation of fixturesJul 11, 2024
@baevbaev merged commitb9975f6 intomainJul 12, 2024
@baevbaev deleted the jasmine-fixtures branchJuly 12, 2024 13:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@baevbaevbaev approved these changes

Assignees

No one assigned

Labels

theme:apiJavascript API related issuetheme:jasmineJasmine related issuetheme:mochaMocha related issuetype:bugSomething isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delatrie@baev
[8]ページ先頭
©2009-2025 Movatter.jp