Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump form-data to fix critical vulnerabilities #182 & #183#1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@aparnajyothi-y
Copy link
Contributor

This PR upgrades the form-data dependency to version 4.0.4 using npm audit fix, resolving a critical security vulnerability identified asGHSA-fjxv-7rqg-78g4.

Vulnerability Summary
form-data previously used Math.random() to generate boundary values for multipart form-encoded data. Because Math.random() is a pseudo-random number generator, it can be predicted if an attacker:

Can observe outputs of Math.random() in the application (e.g., via request headers), and

Can control at least one field in a form-data request.

This predictability allows an attacker to guess the multipart boundary, enabling them to inject additional fields or override values in downstream requests, leading to potential manipulation of internal services.

Affected Package
Package: form-data

Vulnerable Versions: < 2.5.4

Fixed Version: >= 2.5.4 (current version after fix: 4.0.4)

Resolution
This PR brings in the fix by allowing npm audit fix to bump the form-data version to 4.0.4, which no longer uses Math.random() and includes proper randomization for multipart boundaries.

Related issue:
dependabot alert #182
dependabot alert #183

CopilotAI review requested due to automatic review settingsJuly 30, 2025 07:43
@aparnajyothi-yaparnajyothi-y requested a review froma team as acode ownerJuly 30, 2025 07:43
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR upgrades the form-data package to version 4.0.4 to address critical security vulnerabilities (GHSA-fjxv-7rqg-78g4) where Math.random() was used for boundary generation, making multipart forms predictable to attackers.

  • Updated form-data from vulnerable versions to 4.0.4 which uses proper randomization
  • Included transitive dependency updates from npm audit fix
  • Added new license files for dependencies introduced by the security update

Reviewed Changes

Copilot reviewed 19 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
.licenses/npm/form-data-4.0.4.dep.ymlUpdated form-data package version and metadata
.licenses/npm/form-data-2.5.5.dep.ymlUpdated legacy form-data version metadata
.licenses/npm/undici.dep.ymlMinor version bump for undici dependency
.licenses/npm/brace-expansion.dep.ymlPatch version update for brace-expansion
Multiple new.licenses/npm/*.dep.yml filesLicense files for new transitive dependencies

@HarithaVattikutiHarithaVattikuti merged commitfbeb884 intoactions:mainJul 30, 2025
1299 checks passed
@reneleonhardt
Copy link

Wouldn't it be easier to allow to dependabot to fix vulnerabilities and add audit to CI and a daily workflow?

On the other hand, without AI help like CodeRabbit not only dependabot PRs are not being reviewed and merged and stay open for months... 🤷

mergifybot added a commit to ArcadeData/arcadedb that referenced this pull requestSep 8, 2025
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0.Release notes*Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).*> v6.0.0> ------>> What's Changed> -------------->> ### Breaking Changes>> * Upgrade to node 24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/setup-python#1164](https://redirect.github.com/actions/setup-python/pull/1164)>> Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)>> ### Enhancements:>> * Add support for `pip-version` by [`@​priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1129](https://redirect.github.com/actions/setup-python/pull/1129)> * Enhance reading from .python-version by [`@​krystof-k`](https://github.com/krystof-k) in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * Add version parsing from Pipfile by [`@​aradkdj`](https://github.com/aradkdj) in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> ### Bug fixes:>> * Clarify pythonLocation behaviour for PyPy and GraalPy in environment variables by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1183](https://redirect.github.com/actions/setup-python/pull/1183)> * Change missing cache directory error to warning by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1182](https://redirect.github.com/actions/setup-python/pull/1182)> * Add Architecture-Specific PATH Management for Python with --user Flag on Windows by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1122](https://redirect.github.com/actions/setup-python/pull/1122)> * Include python version in PyPy python-version output by [`@​cdce8p`](https://github.com/cdce8p) in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * Update docs: clarification on pip authentication with setup-python by [`@​priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#1156](https://redirect.github.com/actions/setup-python/pull/1156)>> ### Dependency updates:>> * Upgrade idna from 2.9 to 3.7 in /**tests**/data by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#843](https://redirect.github.com/actions/setup-python/pull/843)> * Upgrade form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1163](https://redirect.github.com/actions/setup-python/pull/1163)> * Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIndex.download by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1165](https://redirect.github.com/actions/setup-python/pull/1165)> * Upgrade actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1181](https://redirect.github.com/actions/setup-python/pull/1181)> * Upgrade `@​actions/tool-cache` from 2.0.1 to 2.0.2 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1095](https://redirect.github.com/actions/setup-python/pull/1095)>> New Contributors> ---------------->> * [`@​krystof-k`](https://github.com/krystof-k) made their first contribution in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * [`@​cdce8p`](https://github.com/cdce8p) made their first contribution in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * [`@​aradkdj`](https://github.com/aradkdj) made their first contribution in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> **Full Changelog**: <actions/setup-python@v5...v6.0.0>Commits* [`e797f83`](actions/setup-python@e797f83) Upgrade to node 24 ([#1164](https://redirect.github.com/actions/setup-python/issues/1164))* [`3d1e2d2`](actions/setup-python@3d1e2d2) Revert "Enhance cache-dependency-path handling to support files outside the w...* [`65b0712`](actions/setup-python@65b0712) Clarify pythonLocation behavior for PyPy and GraalPy in environment variables...* [`5b668cf`](actions/setup-python@5b668cf) Bump actions/checkout from 4 to 5 ([#1181](https://redirect.github.com/actions/setup-python/issues/1181))* [`f62a0e2`](actions/setup-python@f62a0e2) Change missing cache directory error to warning ([#1182](https://redirect.github.com/actions/setup-python/issues/1182))* [`9322b3c`](actions/setup-python@9322b3c) Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIn...* [`fbeb884`](actions/setup-python@fbeb884) Bump form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) ([#1163](https://redirect.github.com/actions/setup-python/issues/1163))* [`03bb615`](actions/setup-python@03bb615) Bump idna from 2.9 to 3.7 in /**tests**/data ([#843](https://redirect.github.com/actions/setup-python/issues/843))* [`36da51d`](actions/setup-python@36da51d) Add version parsing from Pipfile ([#1067](https://redirect.github.com/actions/setup-python/issues/1067))* [`3c6f142`](actions/setup-python@3c6f142) update documentation ([#1156](https://redirect.github.com/actions/setup-python/issues/1156))* Additional commits viewable in [compare view](actions/setup-python@a26af69...e797f83)  [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-python&package-manager=github\_actions&previous-version=5.6.0&new-version=6.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---Dependabot commands and options  You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it- `@dependabot cancel merge` will cancel a previously requested merge and block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mergifybot added a commit to robfrank/linklift that referenced this pull requestSep 8, 2025
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0.Release notes*Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).*> v6.0.0> ------>> What's Changed> -------------->> ### Breaking Changes>> * Upgrade to node 24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/setup-python#1164](https://redirect.github.com/actions/setup-python/pull/1164)>> Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)>> ### Enhancements:>> * Add support for `pip-version` by [`@​priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1129](https://redirect.github.com/actions/setup-python/pull/1129)> * Enhance reading from .python-version by [`@​krystof-k`](https://github.com/krystof-k) in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * Add version parsing from Pipfile by [`@​aradkdj`](https://github.com/aradkdj) in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> ### Bug fixes:>> * Clarify pythonLocation behaviour for PyPy and GraalPy in environment variables by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1183](https://redirect.github.com/actions/setup-python/pull/1183)> * Change missing cache directory error to warning by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1182](https://redirect.github.com/actions/setup-python/pull/1182)> * Add Architecture-Specific PATH Management for Python with --user Flag on Windows by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1122](https://redirect.github.com/actions/setup-python/pull/1122)> * Include python version in PyPy python-version output by [`@​cdce8p`](https://github.com/cdce8p) in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * Update docs: clarification on pip authentication with setup-python by [`@​priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#1156](https://redirect.github.com/actions/setup-python/pull/1156)>> ### Dependency updates:>> * Upgrade idna from 2.9 to 3.7 in /**tests**/data by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#843](https://redirect.github.com/actions/setup-python/pull/843)> * Upgrade form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1163](https://redirect.github.com/actions/setup-python/pull/1163)> * Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIndex.download by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1165](https://redirect.github.com/actions/setup-python/pull/1165)> * Upgrade actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1181](https://redirect.github.com/actions/setup-python/pull/1181)> * Upgrade `@​actions/tool-cache` from 2.0.1 to 2.0.2 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1095](https://redirect.github.com/actions/setup-python/pull/1095)>> New Contributors> ---------------->> * [`@​krystof-k`](https://github.com/krystof-k) made their first contribution in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * [`@​cdce8p`](https://github.com/cdce8p) made their first contribution in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * [`@​aradkdj`](https://github.com/aradkdj) made their first contribution in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> **Full Changelog**: <actions/setup-python@v5...v6.0.0>Commits* [`e797f83`](actions/setup-python@e797f83) Upgrade to node 24 ([#1164](https://redirect.github.com/actions/setup-python/issues/1164))* [`3d1e2d2`](actions/setup-python@3d1e2d2) Revert "Enhance cache-dependency-path handling to support files outside the w...* [`65b0712`](actions/setup-python@65b0712) Clarify pythonLocation behavior for PyPy and GraalPy in environment variables...* [`5b668cf`](actions/setup-python@5b668cf) Bump actions/checkout from 4 to 5 ([#1181](https://redirect.github.com/actions/setup-python/issues/1181))* [`f62a0e2`](actions/setup-python@f62a0e2) Change missing cache directory error to warning ([#1182](https://redirect.github.com/actions/setup-python/issues/1182))* [`9322b3c`](actions/setup-python@9322b3c) Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIn...* [`fbeb884`](actions/setup-python@fbeb884) Bump form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) ([#1163](https://redirect.github.com/actions/setup-python/issues/1163))* [`03bb615`](actions/setup-python@03bb615) Bump idna from 2.9 to 3.7 in /**tests**/data ([#843](https://redirect.github.com/actions/setup-python/issues/843))* [`36da51d`](actions/setup-python@36da51d) Add version parsing from Pipfile ([#1067](https://redirect.github.com/actions/setup-python/issues/1067))* [`3c6f142`](actions/setup-python@3c6f142) update documentation ([#1156](https://redirect.github.com/actions/setup-python/issues/1156))* Additional commits viewable in [compare view](actions/setup-python@a26af69...e797f83)  [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-python&package-manager=github\_actions&previous-version=5.6.0&new-version=6.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---Dependabot commands and options  You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it- `@dependabot cancel merge` will cancel a previously requested merge and block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@HarithaVattikutiHarithaVattikutiHarithaVattikuti approved these changes

@priya-kinthalipriya-kinthalipriya-kinthali approved these changes

@gowridurgadgowridurgadgowridurgad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aparnajyothi-y@reneleonhardt@HarithaVattikuti@priya-kinthali@gowridurgad

[8]ページ先頭

©2009-2025 Movatter.jp