- Notifications
You must be signed in to change notification settings - Fork671
Read python version from pyproject.toml (fix #542)#669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Is anyone maintaining this action? |
Hello@dariocurr. Sorry for the late response. Could you please fix the code because it looks like you have the recursive calling of some function. |
ContributorAuthor
dariocurr commentedJun 6, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry, I fixed it, it was a silly error. |
I guess we are ready to give it another run |
Can I have more info about the failing test? |
Hello@dariocurr. If I understood correctly you changed that python-version input could accept values from toml files ? If it's so could you please change to python-version-file input only. Besides, I'm not sure about toml library because the last update was 4 years ago. Can we achieve required behaviour without extra library ? |
I didn't understand your first request, can you please explain it better? |
I replaced |
| }).join('\n') | ||
| if (escaped.slice(-1) === '"') escaped += '\\\n' | ||
| return '"""\n' + escaped + '"""' | ||
| } |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
This does not escape backslash characters in the input.
I don't have a clue about the failing checks and CodeQL issue |
| -name:Run with setup-python ==3.8 | ||
| uses:./ | ||
| with: | ||
| python-version:'==3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please keep syntax specific for toml files for python-version-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you explain better the expected behaviour you desire?
ContributorAuthor
dariocurrJun 23, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's quite difficult for me to keep up with this PR with feedbacks once a week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Previously such type of syntax was not supported by setup-python. If I understood correctly it comes from the toml file log. I'd like to keep this logic in the scope of python-version-file input.
ContributorAuthor
dariocurrJun 23, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You already supported it because you parse versions usingsemver. I did not change the parsing behavior.
You were already supporting it, but you were not testing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for your response@dariocurr. It is right that '==3.8' is supported by SemVer but as I suppose that>=3.8,<3.10 is not supported. If it is so could you please keep logic regarding to toml to python-version-file parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's why I added this line to convert>=3.8,<3.10 to>=3.8 <3.10:
https://github.com/dariocurr/setup-python/blob/6f8266d242a075e81d1967d6165cd0af7e56d049/src/setup-python.ts#L73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is right that we need to change it to SemVer syntax but I'd like to keep it this syntax for in scope of python-version-file input so when you get it from the toml file it get parsed but it should not be allowed to pass it through python-version input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done with39c1ae5
| if(versions.length&&versionFile){ | ||
| core.warning( | ||
| 'Both python-version and python-version-file inputs are specified, only python-version will be used.' | ||
| functionresolveVersionInputFromDefaultFile():string[]{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you please removepyproject.toml. We'd like to keep only.python-version file as a default option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMHO it would be a nice option since is the python standard (PEP 621) and this action is calledsetup-python.
But as you wish. I edited it in the latest commit
I fixed the test that was failing |
I fixed also the prettier issue |
Ready to go? |
dmitry-shibanov approved these changesJun 28, 2023
Hello@dariocurr. Thank you for your pull request. I'll test the action additionally this week. After that we'll prepare a new release next week. |
BrandonLWhite commentedJun 28, 2023
Wow! Thanks@dariocurr for implementing this and sticking with it! Little improvements to the Python ecosystem like this that simplify and unify project config are huge benefits. |
Thank you for accepting the PR. |
When will it be released? |
welpaolo referenced this pull request in canonical/spark-k8s-toolkit-pyAug 14, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [actions/setup-python](https://togithub.com/actions/setup-python) |action | major | `v2.2.2` -> `v4.7.0` ||[canonical/data-platform-workflows](https://togithub.com/canonical/data-platform-workflows)| action | major | `v2` -> `v4` |---### Release Notes<details><summary>actions/setup-python (actions/setup-python)</summary>###[`v4.7.0`](https://togithub.com/actions/setup-python/releases/tag/v4.7.0)[CompareSource](https://togithub.com/actions/setup-python/compare/v4.6.1...v4.7.0)In scope of this release, the support for reading python version frompyproject.toml was added([https://github.com/actions/setup-python/pull/669](https://togithub.com/actions/setup-python/pull/669)).```yaml - name: Setup Python uses: actions/setup-python@v4 with: python-version-file: pyproject.toml```##### Besides, it includes such changes as:- Bump tough-cookie and[@​azure/ms-rest-js](https://togithub.com/azure/ms-rest-js) by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/actions/setup-python/pull/697](https://togithub.com/actions/setup-python/pull/697)- Bump semver from 7.3.8 to 7.5.2 by[@​dependabot](https://togithub.com/dependabot) in[https://github.com/actions/setup-python/pull/692](https://togithub.com/actions/setup-python/pull/692)- Fix typos found by codespell by[@​DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos)in[https://github.com/actions/setup-python/pull/650](https://togithub.com/actions/setup-python/pull/650)#### New Contributors- [@​dariocurr](https://togithub.com/dariocurr) made their firstcontribution in[https://github.com/actions/setup-python/pull/669](https://togithub.com/actions/setup-python/pull/669)-[@​DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos)made their first contribution in[https://github.com/actions/setup-python/pull/650](https://togithub.com/actions/setup-python/pull/650)**Full Changelog**:actions/setup-python@v4...v4.7.0###[`v4.6.1`](https://togithub.com/actions/setup-python/releases/tag/v4.6.1)[CompareSource](https://togithub.com/actions/setup-python/compare/v4.6.0...v4.6.1)#### What's Changed- Fix `allow-prereleases` sample configuration by[@​mayeut](https://togithub.com/mayeut) in[https://github.com/actions/setup-python/pull/615](https://togithub.com/actions/setup-python/pull/615)- Fix a incorrect link advanced-usage.md by[@​siyuan0322](https://togithub.com/siyuan0322) in[https://github.com/actions/setup-python/pull/657](https://togithub.com/actions/setup-python/pull/657)- Remove implicit dependency by[@​nikolai-laevskii](https://togithub.com/nikolai-laevskii) in[https://github.com/actions/setup-python/pull/668](https://togithub.com/actions/setup-python/pull/668)- Automatic update of configuration files from 05/23/2023 by[@​github-actions](https://togithub.com/github-actions) in[https://github.com/actions/setup-python/pull/671](https://togithub.com/actions/setup-python/pull/671)- Add warning for python 2.7 on release/v4 by[@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in[https://github.com/actions/setup-python/pull/673](https://togithub.com/actions/setup-python/pull/673)#### New Contributors- [@​siyuan0322](https://togithub.com/siyuan0322) made their firstcontribution in[https://github.com/actions/setup-python/pull/657](https://togithub.com/actions/setup-python/pull/657)- [@​nikolai-laevskii](https://togithub.com/nikolai-laevskii) madetheir first contribution in[https://github.com/actions/setup-python/pull/668](https://togithub.com/actions/setup-python/pull/668)**Full Changelog**:actions/setup-python@v4...v4.6.1###[`v4.6.0`](https://togithub.com/actions/setup-python/releases/tag/v4.6.0):Add allow-prereleases input[CompareSource](https://togithub.com/actions/setup-python/compare/v4.5.0...v4.6.0)In scope of this release we added a new input (`allow-prereleases`) toallow [falling back to pre-release versions of Python when a matching GAversion of Python is notavailable](https://togithub.com/actions/setup-python/pull/414)```yamlsteps: - uses: actions/checkout@v3 - uses: actions/setup-python@v4 with: python-version: 3.12 allow-prereleases: true```Besides, we added such changes as:- Fix bug to trim new line for PyPy version:[https://github.com/actions/setup-python/pull/610](https://togithub.com/actions/setup-python/pull/610)- Added pip dependency file to generate hash from it:[https://github.com/actions/setup-python/pull/604](https://togithub.com/actions/setup-python/pull/604)- Improved error handling for saving and restoring cache:[https://github.com/actions/setup-python/pull/618](https://togithub.com/actions/setup-python/pull/618)- Add warning if cache paths are empty:[https://github.com/actions/setup-python/pull/642](https://togithub.com/actions/setup-python/pull/642)###[`v4.5.0`](https://togithub.com/actions/setup-python/releases/tag/v4.5.0):Fix cache issue for Poetry projects located in subfolders[CompareSource](https://togithub.com/actions/setup-python/compare/v4.4.0...v4.5.0)In scope of this release we fixed cache issue for Poetry projectslocated in subfolders([https://github.com/actions/setup-python/issues/446](https://togithub.com/actions/setup-python/issues/446)).Besides that we updated json5 version from 2.2.0 to 2.2.3([https://github.com/actions/setup-python/pull/579](https://togithub.com/actions/setup-python/pull/579)).###[`v4.4.0`](https://togithub.com/actions/setup-python/releases/tag/v4.4.0):Add support to install multiple python versions[CompareSource](https://togithub.com/actions/setup-python/compare/v4.3.1...v4.4.0)In scope of this release we added support to [install multiple pythonversions](https://togithub.com/actions/setup-python/pull/567). For thisyou can try to use this snippet:```yaml - uses: actions/setup-python@v4 with: python-version: | 3.8 3.9 3.10```Besides, we changed logic with throwing the error for GHES if cache isunavailable to warn([https://github.com/actions/setup-python/pull/566](https://togithub.com/actions/setup-python/pull/566)).###[`v4.3.1`](https://togithub.com/actions/setup-python/releases/tag/v4.3.1):Improve error handling and messages[CompareSource](https://togithub.com/actions/setup-python/compare/v4.3.0...v4.3.1)In scope of this release we added improved error message to putoperating system and its version in the logs([https://github.com/actions/setup-python/pull/559](https://togithub.com/actions/setup-python/pull/559)).Besides, the release- fixes issue about [specifying architecture for pypy-nightly onWindows](https://togithub.com/actions/setup-python/issues/518) withrelated [pullrequest](https://togithub.com/actions/setup-python/pull/520).- improves error handling for Http Errors([https://github.com/actions/setup-python/pull/511](https://togithub.com/actions/setup-python/pull/511)).- updates minimatch([https://github.com/actions/setup-python/pull/558](https://togithub.com/actions/setup-python/pull/558)).###[`v4.3.0`](https://togithub.com/actions/setup-python/releases/tag/v4.3.0)[CompareSource](https://togithub.com/actions/setup-python/compare/v4.2.0...v4.3.0)- Update [@​actions/core](https://togithub.com/actions/core) to1.10.0 version[#​517](https://togithub.com/actions/setup-python/issues/517)- Update [@​actions/cache](https://togithub.com/actions/cache) to3.0.4 version[#​499](https://togithub.com/actions/setup-python/issues/499)- Only use github.token on github.com[#​443](https://togithub.com/actions/setup-python/issues/443)- Improvement of documentation[#​477](https://togithub.com/actions/setup-python/issues/477)[#​479](https://togithub.com/actions/setup-python/issues/479)[#​491](https://togithub.com/actions/setup-python/issues/491)[#​492](https://togithub.com/actions/setup-python/issues/492)###[`v4.2.0`](https://togithub.com/actions/setup-python/releases/tag/v4.2.0):Add check-latest input and bug fixes[CompareSource](https://togithub.com/actions/setup-python/compare/v4.1.0...v4.2.0)In scope of this release we addthe [check-latest](https://togithub.com/actions/setup-python/pull/406) input.If check-latest is set to true, the action first checks if the cachedversion is the latest one. If the locally cached version is not the mostup-to-date, the version will then be downloadedfrom [python-versions](https://togithub.com/actions/python-versions) repository.By default check-latest is set to false. For PyPy it will to try toreachhttps://downloads.python.org/pypy/versions.json##### Example of usage:```yamlsteps: - uses: actions/checkout@v3 - uses: actions/setup-python@v4 with: python-version: '3.9' check-latest: true - run: python --version```Besides, it includes such changes as- Resolved logs for python-version and file inputs:[https://github.com/actions/setup-python/pull/465](https://togithub.com/actions/setup-python/pull/465)- Added linux os release info to primary key:[https://github.com/actions/setup-python/pull/467](https://togithub.com/actions/setup-python/pull/467)- Added fix to change Python versions for poetry:[https://github.com/actions/setup-python/pull/445](https://togithub.com/actions/setup-python/pull/445)- Fix Tool Path handling for self-hosted runners:[https://github.com/actions/setup-python/pull/466](https://togithub.com/actions/setup-python/pull/466)###[`v4.1.0`](https://togithub.com/actions/setup-python/releases/tag/v4.1.0)[CompareSource](https://togithub.com/actions/setup-python/compare/v4.0.0...v4.1.0)In scope of this pull request we updated `actions/cache` package as thenew version contains fixes for [caching errorhandling](https://togithub.com/actions/setup-python/pull/448). Moreover,we added a new input[update-environment](https://togithub.com/actions/setup-python/pull/411).This option allows to specify if the action shall update environmentvariables (default) or not.##### Update-environment input```yaml - name: setup-python 3.9 uses: actions/setup-python@v4 with: python-version: 3.9 update-environment: false```**Besides, we added such changes as:**- Allow python-version-file to be a relative path:[https://github.com/actions/setup-python/pull/431](https://togithub.com/actions/setup-python/pull/431)- Added new environment variables for `Cmake`:[https://github.com/actions/setup-python/pull/440](https://togithub.com/actions/setup-python/pull/440)- Updated error message for resolveVersion:[https://github.com/actions/setup-python/pull/450](https://togithub.com/actions/setup-python/pull/450)- Assign default value of `AGENT_TOOLSDIRECTORY` if not set:[https://github.com/actions/setup-python/pull/394](https://togithub.com/actions/setup-python/pull/394)###[`v4.0.0`](https://togithub.com/actions/setup-python/releases/tag/v4.0.0)[CompareSource](https://togithub.com/actions/setup-python/compare/v3.1.4...v4.0.0)##### What's Changed- Support for `python-version-file` input:[#​336](https://togithub.com/actions/setup-python/issues/336)Example of usage:```yaml- uses: actions/setup-python@v4 with: python-version-file: '.python-version' # Read python version from a file- run: python my_script.py```There is no default python version for this `setup-python` majorversion, the action requires to specify either `python-version` input or`python-version-file` input. If the `python-version` input is notspecified the action will try to read required version from file from`python-version-file` input.- Use pypyX.Y for PyPy `python-version` input:[#​349](https://togithub.com/actions/setup-python/issues/349)Example of usage:```yaml- uses: actions/setup-python@v4 with: python-version: 'pypy3.9' # pypy-X.Y kept for backward compatibility- run: python my_script.py```- `RUNNER_TOOL_CACHE` environment variable is equal`AGENT_TOOLSDIRECTORY`:[#​338](https://togithub.com/actions/setup-python/issues/338)- Bugfix: create missing `pypyX.Y` symlinks:[#​347](https://togithub.com/actions/setup-python/issues/347)- `PKG_CONFIG_PATH` environment variable:[#​400](https://togithub.com/actions/setup-python/issues/400)- Added `python-path` output:[#​405](https://togithub.com/actions/setup-python/issues/405) `python-path` output contains Python executable path.- Updated `zeit/ncc` to `vercel/ncc` package:[#​393](https://togithub.com/actions/setup-python/issues/393)- Bugfix: fixed output for prerelease version of poetry:[#​409](https://togithub.com/actions/setup-python/issues/409)- Made `pythonLocation` environment variable consistent for Python andPyPy:[#​418](https://togithub.com/actions/setup-python/issues/418)- Bugfix for `3.x-dev` syntax:[#​417](https://togithub.com/actions/setup-python/issues/417)- Other improvements:[#​318](https://togithub.com/actions/setup-python/issues/318)[#​396](https://togithub.com/actions/setup-python/issues/396)[#​384](https://togithub.com/actions/setup-python/issues/384)[#​387](https://togithub.com/actions/setup-python/issues/387)[#​388](https://togithub.com/actions/setup-python/issues/388)###[`v3.1.4`](https://togithub.com/actions/setup-python/releases/tag/v3.1.4)[CompareSource](https://togithub.com/actions/setup-python/compare/v3.1.3...v3.1.4)#### What's ChangedIn the scope of this patch release, the warning for deprecating Python2.x was added in[https://github.com/actions/setup-python/pull/674](https://togithub.com/actions/setup-python/pull/674)by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov)For more information, check out[https://github.com/actions/setup-python/issues/672](https://togithub.com/actions/setup-python/issues/672)**Full Changelog**:actions/setup-python@v3...v3.1.4###[`v3.1.3`](https://togithub.com/actions/setup-python/releases/tag/v3.1.3):Update actions/core to 1.10.0 for v3[CompareSource](https://togithub.com/actions/setup-python/compare/v3.1.2...v3.1.3)In scope of this release we update actions/core to 1.10.0 for v3 majortag:[https://github.com/actions/setup-python/pull/624](https://togithub.com/actions/setup-python/pull/624)###[`v3.1.2`](https://togithub.com/actions/setup-python/releases/tag/v3.1.2):Update actions/cache version to 2.0.2[CompareSource](https://togithub.com/actions/setup-python/compare/v3.1.1...v3.1.2)In scope of this release we updated `actions/cache` package as the newversion contains fixes related to GHES 3.5([https://github.com/actions/setup-python/pull/382](https://togithub.com/actions/setup-python/pull/382))###[`v3.1.1`](https://togithub.com/actions/setup-python/releases/tag/v3.1.1):Add "cache-hit" output and fix "python-version"output for PyPy[CompareSource](https://togithub.com/actions/setup-python/compare/v3.1.0...v3.1.1)This release introduces new output cache-hit([https://github.com/actions/setup-python/pull/373](https://togithub.com/actions/setup-python/pull/373))and fix python-version output for PyPy([https://github.com/actions/setup-python/pull/365](https://togithub.com/actions/setup-python/pull/365))The cache-hit output contains boolean value indicating that an exactmatch was found for the key. It shows that the action uses alreadyexisting cache or not. The output is available only if cache is enabled.The python-version contains version of Python or PyPy.###[`v3.1.0`](https://togithub.com/actions/setup-python/releases/tag/v3.1.0):Support caching poetry dependencies and caching on GHES 3.5[CompareSource](https://togithub.com/actions/setup-python/compare/v3.0.0...v3.1.0)- In the scope of this release, we added [support for caching from GHES3.5](https://togithub.com/actions/setup-python/issues/362) and fixed thedownload issue for files > 2GB during restore.- Caching poetry dependencies```yamlsteps:- uses: actions/checkout@v3- name: Install poetry run: pipx install poetry- uses: actions/setup-python@v3 with: python-version: '3.9' cache: 'poetry'- run: poetry install- run: poetry run pytest```###[`v3.0.0`](https://togithub.com/actions/setup-python/releases/tag/v3.0.0)[CompareSource](https://togithub.com/actions/setup-python/compare/v2.3.4...v3.0.0)#### What's Changed- Update default runtime to node16([https://github.com/actions/setup-python/pull/340](https://togithub.com/actions/setup-python/pull/340))- Update `package-lock.json` file version to 2, `@types/node` to16.11.25 and `typescript` to 4.2.3([https://github.com/actions/setup-python/pull/341](https://togithub.com/actions/setup-python/pull/341))- Remove legacy `pypy2` and `pypy3` keywords([https://github.com/actions/setup-python/pull/342](https://togithub.com/actions/setup-python/pull/342))##### Breaking ChangesWith the update to Node 16, all scripts will now be run with Node 16rather than Node 12.This new major release removes support of legacy `pypy2` and `pypy3`keywords. Please use more specific and flexible syntax to specify a PyPyversion:```yamljobs: build: runs-on: ubuntu-latest strategy: matrix: python-version: - 'pypy-2.7' # the latest available version of PyPy that supports Python 2.7 - 'pypy-3.8' # the latest available version of PyPy that supports Python 3.8 - 'pypy-3.8-v7.3.8' # Python 3.8 and PyPy 7.3.8 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v3 with: python-version: ${{ matrix.python-version }}```See more usage examples in the[documentation](https://togithub.com/actions/setup-python#specifying-a-pypy-version)###[`v2.3.4`](https://togithub.com/actions/setup-python/releases/tag/v2.3.4)[CompareSource](https://togithub.com/actions/setup-python/compare/v2.3.3...v2.3.4)#### What's ChangedIn the scope of this patch release, the warning for deprecating Python2.x was added in[https://github.com/actions/setup-python/pull/675](https://togithub.com/actions/setup-python/pull/675)by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov)For more information, check out[https://github.com/actions/setup-python/issues/672](https://togithub.com/actions/setup-python/issues/672)**Full Changelog**:actions/setup-python@v2...v2.3.4###[`v2.3.3`](https://togithub.com/actions/setup-python/releases/tag/v2.3.3):Update actions/core to 1.10.0 for v2[CompareSource](https://togithub.com/actions/setup-python/compare/v2.3.2...v2.3.3)In scope of this release we update actions/core to 1.10.0 for v2 majortag:[https://github.com/actions/setup-python/pull/533](https://togithub.com/actions/setup-python/pull/533).###[`v2.3.2`](https://togithub.com/actions/setup-python/releases/tag/v2.3.2):Update primary and restore keys for pip[CompareSource](https://togithub.com/actions/setup-python/compare/v2.3.1...v2.3.2)In scope of this release we [include a version of python in restore andprimary cache keys forpip](https://togithub.com/actions/setup-python/pull/303). Besides, weadd temporary fix for Windows caching[issue](https://togithub.com/actions/setup-python/pull/332), that the`pip cache dir` command returns non zero exit code or writes to stderr.Moreover we updated [node-fetchdependency](https://togithub.com/actions/setup-python/pull/327).###[`v2.3.1`](https://togithub.com/actions/setup-python/releases/tag/v2.3.1):Update actions/cache version to 1.0.8[CompareSource](https://togithub.com/actions/setup-python/compare/v2.3.0...v2.3.1)We haveupdated [actions/cache](https://togithub.com/actions/toolkit/blob/main/packages/cache/RELEASES.md#108) dependencyversion to 1.0.8 to support 10GB cache upload###[`v2.3.0`](https://togithub.com/actions/setup-python/releases/tag/v2.3.0):Support caching dependencies[CompareSource](https://togithub.com/actions/setup-python/compare/v2.2.2...v2.3.0)This release introduces dependency caching support([https://github.com/actions/setup-python/pull/266](https://togithub.com/actions/setup-python/pull/266))#### Caching dependencies.The action has a built-in functionality for caching and restoringpip/pipenv dependencies. The `cache` input is optional, and caching isturned off by default.Besides, this release introduces dependency caching support for monorepos and repositories with complex structure.By default, the action searches for the dependency file(requirements.txt for pip or Pipfile.lock for pipenv) in the wholerepository. Use the `cache-dependency-path` input for cases when youwant to override current behaviour and use different file for hashgeneration (for example requirements-dev.txt). This input supportswildcards or a list of file names for caching multiple dependencies.##### Caching pip dependencies: steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 with: python-version: '3.9' cache: 'pip' - run: pip install -r requirements.txt - run: pip test##### Caching pipenv dependencies: steps: - uses: actions/checkout@v2 - name: Install pipenv run: pipx install pipenv - uses: actions/setup-python@v2 with: python-version: '3.9' cache: 'pipenv' - run: pipenv install - run: pipenv test##### Change dependency file: steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 with: python-version: '3.9' cache: 'pip' cache-dependency-path: '**/requirements-dev.txt' - run: pip install -r subdirectory/requirements-dev.txt - run: pip test</details><details><summary>canonical/data-platform-workflows(canonical/data-platform-workflows)</summary>###[`v4`](https://togithub.com/canonical/data-platform-workflows/compare/v3...v4)[CompareSource](https://togithub.com/canonical/data-platform-workflows/compare/v3...v4)###[`v3`](https://togithub.com/canonical/data-platform-workflows/compare/v2...v3)[CompareSource](https://togithub.com/canonical/data-platform-workflows/compare/v2...v3)</details>---### Configuration📅 **Schedule**: Branch creation - "after 1am and before 2am on saturday"in timezone Etc/UTC, Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/canonical/spark-k8s-toolkit-py).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
zoj613 commentedAug 26, 2023
This seems like a great addition and should eliminate the need to specify matrix:python-version:[ ... ] Usually I use |
We could add an output value to use in the following steps |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Hi, I'm Dario, a tech PO athiop.
Description:
This PR enables the action to read the Python version from the
pyproject.tomlfile (or another TOML file if specified) both for standard python (PEP 621,PEP 508) and poetry (https://python-poetry.org/docs/basic-usage/).More in detail, it deserializes the TOML files using thetoml package and then navigates it to extract the Python versions.
Related issue:
Check list:
Notes:
src/setup-python.ts? I didn't find any test related to those functions>=3.9,<=3.10bounds are transformed insemver-like bounds.python-versionfile used if no parameters are provided.github/workflows/test-python.yml.github/workflows/e2e-tests.yml