Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add version parsing from Pipfile#1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aradkdj
Copy link
Contributor

Description:
Add version parsing from a Pipfile, passed through thepython-version-file option.

Related issue:
#574

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@aradkdjaradkdj requested a review froma team as acode ownerMarch 27, 2025 03:04
@aradkdjaradkdjforce-pushed thefeature/add-version-parsing-from-Pipfile branch fromf387444 to0fc6a29CompareMay 30, 2025 23:11
@mahabaleshwars
Copy link
Contributor

Hi@aradkdj,
The checks are currently failing on your PR. Could you please address the issues and pull the latest updates from the main branch? Once that's done, we can proceed with the review.

Thanks!

@aradkdjaradkdjforce-pushed thefeature/add-version-parsing-from-Pipfile branch from0fc6a29 toc44ab2eCompareJune 4, 2025 03:16
@mahabaleshwars
Copy link
Contributor

Hi@aradkdj,
The checks are still failing. Please review the previous feedback comment, and let me know if you need any assistance to move forward.

@mahabaleshwarsmahabaleshwars self-assigned thisJun 9, 2025
@aradkdj
Copy link
ContributorAuthor

Sure. I took a look at it and could not figure out why it's failing on CI but not on the unit tests. Any pointer would be appreciated

@mahabaleshwars
Copy link
Contributor

Hi@aradkdj,
This issue is occurring due to an incorrect file name specified in the .yml file. It should be 'Pipfile' instead of 'Pipenv'. The logic performs a strict check on the file name:

else if (versionFile.match('Pipfile')) {  return getVersionInputFromPipfileFile(versionFile);}

Since 'Pipenv' doesn't match 'Pipfile', the corresponding logic isn't triggered. Please update the file name to resolve the issue.

aradkdj reacted with rocket emoji

@aradkdjaradkdjforce-pushed thefeature/add-version-parsing-from-Pipfile branch fromc44ab2e toe87e3e9CompareJune 12, 2025 23:20
@aradkdj
Copy link
ContributorAuthor

Sorry I missed that. It should be fixed now

@mahabaleshwars
Copy link
Contributor

Hi@aradkdj,
It looks like some checks are currently failing for this pull request. To help get this PR ready for review, could you please make sure your changes are up to date with the latest changes in setup-python? You can rebase or merge as necessary.

If you need any help interpreting the logs or fixing a specific error, feel free to share the error details here and we can assist further.

@aradkdj
Copy link
ContributorAuthor

Merged and checked if the dist changes. But it didn't. If I understand the errors correctly they come from annotations about the installedpip version. Is there anything else I could do to fix it?

@mahabaleshwars
Copy link
Contributor

Hi@aradkdj,
It looks like the issue is still not resolved — your PR branch might be missing the latest changes from main. Please update your forked repo’s main branch with the upstream setup-python, and then merge those changes into your branch.
After updating, please rebuild the dist files and push the changes.

@aradkdjaradkdjforce-pushed thefeature/add-version-parsing-from-Pipfile branch 2 times, most recently from4302de9 to9485ba7CompareJune 25, 2025 17:02
@aradkdjaradkdjforce-pushed thefeature/add-version-parsing-from-Pipfile branch from9485ba7 toee0eb5bCompareJuly 4, 2025 21:50
@aradkdjaradkdjforce-pushed thefeature/add-version-parsing-from-Pipfile branch fromee0eb5b tob62f6a8CompareJuly 6, 2025 00:45
@aradkdj
Copy link
ContributorAuthor

@mahabaleshwars this should be passing now. Sorry for the delay

mahabaleshwars reacted with thumbs up emoji

Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds support for parsing Python versions from a Pipfile via thepython-version-file option.

  • IntroducesgetVersionInputFromPipfileFile and hooks it intogetVersionInputFromFile.
  • Updates docs and CI workflows to demonstrate and test Pipfile usage.
  • Adds unit tests coveringpython_version,python_full_version, and empty Pipfile cases.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
src/utils.tsImplementgetVersionInputFromPipfileFile and integrate it
docs/advanced-usage.mdDocument how to use Pipfile withpython-version-file
tests/utils.test.tsAdd tests for Pipfile parsing scenarios
.github/workflows/test-python.ymlAdd Pipfile-based setup jobs forpython_version andpython_full_version
.github/workflows/test-python-freethreaded.ymlAdd equivalent Pipfile jobs in the freethreaded workflow

aradkdjand others added4 commitsJuly 11, 2025 12:05
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@HarithaVattikutiHarithaVattikuti merged commit36da51d intoactions:mainJul 24, 2025
1299 checks passed
mergifybot added a commit to ArcadeData/arcadedb that referenced this pull requestSep 8, 2025
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0.Release notes*Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).*> v6.0.0> ------>> What's Changed> -------------->> ### Breaking Changes>> * Upgrade to node 24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/setup-python#1164](https://redirect.github.com/actions/setup-python/pull/1164)>> Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)>> ### Enhancements:>> * Add support for `pip-version` by [`@​priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1129](https://redirect.github.com/actions/setup-python/pull/1129)> * Enhance reading from .python-version by [`@​krystof-k`](https://github.com/krystof-k) in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * Add version parsing from Pipfile by [`@​aradkdj`](https://github.com/aradkdj) in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> ### Bug fixes:>> * Clarify pythonLocation behaviour for PyPy and GraalPy in environment variables by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1183](https://redirect.github.com/actions/setup-python/pull/1183)> * Change missing cache directory error to warning by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1182](https://redirect.github.com/actions/setup-python/pull/1182)> * Add Architecture-Specific PATH Management for Python with --user Flag on Windows by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1122](https://redirect.github.com/actions/setup-python/pull/1122)> * Include python version in PyPy python-version output by [`@​cdce8p`](https://github.com/cdce8p) in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * Update docs: clarification on pip authentication with setup-python by [`@​priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#1156](https://redirect.github.com/actions/setup-python/pull/1156)>> ### Dependency updates:>> * Upgrade idna from 2.9 to 3.7 in /**tests**/data by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#843](https://redirect.github.com/actions/setup-python/pull/843)> * Upgrade form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1163](https://redirect.github.com/actions/setup-python/pull/1163)> * Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIndex.download by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1165](https://redirect.github.com/actions/setup-python/pull/1165)> * Upgrade actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1181](https://redirect.github.com/actions/setup-python/pull/1181)> * Upgrade `@​actions/tool-cache` from 2.0.1 to 2.0.2 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1095](https://redirect.github.com/actions/setup-python/pull/1095)>> New Contributors> ---------------->> * [`@​krystof-k`](https://github.com/krystof-k) made their first contribution in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * [`@​cdce8p`](https://github.com/cdce8p) made their first contribution in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * [`@​aradkdj`](https://github.com/aradkdj) made their first contribution in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> **Full Changelog**: <actions/setup-python@v5...v6.0.0>Commits* [`e797f83`](actions/setup-python@e797f83) Upgrade to node 24 ([#1164](https://redirect.github.com/actions/setup-python/issues/1164))* [`3d1e2d2`](actions/setup-python@3d1e2d2) Revert "Enhance cache-dependency-path handling to support files outside the w...* [`65b0712`](actions/setup-python@65b0712) Clarify pythonLocation behavior for PyPy and GraalPy in environment variables...* [`5b668cf`](actions/setup-python@5b668cf) Bump actions/checkout from 4 to 5 ([#1181](https://redirect.github.com/actions/setup-python/issues/1181))* [`f62a0e2`](actions/setup-python@f62a0e2) Change missing cache directory error to warning ([#1182](https://redirect.github.com/actions/setup-python/issues/1182))* [`9322b3c`](actions/setup-python@9322b3c) Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIn...* [`fbeb884`](actions/setup-python@fbeb884) Bump form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) ([#1163](https://redirect.github.com/actions/setup-python/issues/1163))* [`03bb615`](actions/setup-python@03bb615) Bump idna from 2.9 to 3.7 in /**tests**/data ([#843](https://redirect.github.com/actions/setup-python/issues/843))* [`36da51d`](actions/setup-python@36da51d) Add version parsing from Pipfile ([#1067](https://redirect.github.com/actions/setup-python/issues/1067))* [`3c6f142`](actions/setup-python@3c6f142) update documentation ([#1156](https://redirect.github.com/actions/setup-python/issues/1156))* Additional commits viewable in [compare view](actions/setup-python@a26af69...e797f83)  [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-python&package-manager=github\_actions&previous-version=5.6.0&new-version=6.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---Dependabot commands and options  You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it- `@dependabot cancel merge` will cancel a previously requested merge and block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mergifybot added a commit to robfrank/linklift that referenced this pull requestSep 8, 2025
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0.Release notes*Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).*> v6.0.0> ------>> What's Changed> -------------->> ### Breaking Changes>> * Upgrade to node 24 by [`@​salmanmkc`](https://github.com/salmanmkc) in [actions/setup-python#1164](https://redirect.github.com/actions/setup-python/pull/1164)>> Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)>> ### Enhancements:>> * Add support for `pip-version` by [`@​priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1129](https://redirect.github.com/actions/setup-python/pull/1129)> * Enhance reading from .python-version by [`@​krystof-k`](https://github.com/krystof-k) in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * Add version parsing from Pipfile by [`@​aradkdj`](https://github.com/aradkdj) in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> ### Bug fixes:>> * Clarify pythonLocation behaviour for PyPy and GraalPy in environment variables by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1183](https://redirect.github.com/actions/setup-python/pull/1183)> * Change missing cache directory error to warning by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1182](https://redirect.github.com/actions/setup-python/pull/1182)> * Add Architecture-Specific PATH Management for Python with --user Flag on Windows by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1122](https://redirect.github.com/actions/setup-python/pull/1122)> * Include python version in PyPy python-version output by [`@​cdce8p`](https://github.com/cdce8p) in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * Update docs: clarification on pip authentication with setup-python by [`@​priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#1156](https://redirect.github.com/actions/setup-python/pull/1156)>> ### Dependency updates:>> * Upgrade idna from 2.9 to 3.7 in /**tests**/data by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#843](https://redirect.github.com/actions/setup-python/pull/843)> * Upgrade form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1163](https://redirect.github.com/actions/setup-python/pull/1163)> * Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIndex.download by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1165](https://redirect.github.com/actions/setup-python/pull/1165)> * Upgrade actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1181](https://redirect.github.com/actions/setup-python/pull/1181)> * Upgrade `@​actions/tool-cache` from 2.0.1 to 2.0.2 by [`@​dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1095](https://redirect.github.com/actions/setup-python/pull/1095)>> New Contributors> ---------------->> * [`@​krystof-k`](https://github.com/krystof-k) made their first contribution in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787)> * [`@​cdce8p`](https://github.com/cdce8p) made their first contribution in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110)> * [`@​aradkdj`](https://github.com/aradkdj) made their first contribution in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067)>> **Full Changelog**: <actions/setup-python@v5...v6.0.0>Commits* [`e797f83`](actions/setup-python@e797f83) Upgrade to node 24 ([#1164](https://redirect.github.com/actions/setup-python/issues/1164))* [`3d1e2d2`](actions/setup-python@3d1e2d2) Revert "Enhance cache-dependency-path handling to support files outside the w...* [`65b0712`](actions/setup-python@65b0712) Clarify pythonLocation behavior for PyPy and GraalPy in environment variables...* [`5b668cf`](actions/setup-python@5b668cf) Bump actions/checkout from 4 to 5 ([#1181](https://redirect.github.com/actions/setup-python/issues/1181))* [`f62a0e2`](actions/setup-python@f62a0e2) Change missing cache directory error to warning ([#1182](https://redirect.github.com/actions/setup-python/issues/1182))* [`9322b3c`](actions/setup-python@9322b3c) Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIn...* [`fbeb884`](actions/setup-python@fbeb884) Bump form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) ([#1163](https://redirect.github.com/actions/setup-python/issues/1163))* [`03bb615`](actions/setup-python@03bb615) Bump idna from 2.9 to 3.7 in /**tests**/data ([#843](https://redirect.github.com/actions/setup-python/issues/843))* [`36da51d`](actions/setup-python@36da51d) Add version parsing from Pipfile ([#1067](https://redirect.github.com/actions/setup-python/issues/1067))* [`3c6f142`](actions/setup-python@3c6f142) update documentation ([#1156](https://redirect.github.com/actions/setup-python/issues/1156))* Additional commits viewable in [compare view](actions/setup-python@a26af69...e797f83)  [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-python&package-manager=github\_actions&previous-version=5.6.0&new-version=6.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---Dependabot commands and options  You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it- `@dependabot cancel merge` will cancel a previously requested merge and block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@HarithaVattikutiHarithaVattikutiHarithaVattikuti approved these changes

@aparnajyothi-yaparnajyothi-yaparnajyothi-y approved these changes

@mahabaleshwarsmahabaleshwarsmahabaleshwars approved these changes

@lmvysakhlmvysakhlmvysakh approved these changes

Assignees

@mahabaleshwarsmahabaleshwars

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aradkdj@mahabaleshwars@HarithaVattikuti@aparnajyothi-y@lmvysakh
[8]ページ先頭
©2009-2025 Movatter.jp