- Notifications
You must be signed in to change notification settings - Fork810
Upgrade to node 24#888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Upgrading action to node 24 since new runner version.
djohnson20589-jpg commentedAug 7, 2025
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR upgrades the GitHub Action from Node.js 20 to Node.js 24 to align with the newer runner version requirements.
- Updates the action runtime environment from
node20tonode24 - Updates Node.js type definitions and engine requirements to version 24
- Fixes TypeScript compilation issues that arose from stricter type checking in Node 24
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| action.yml | Updates the action runtime fromnode20 tonode24 |
| package.json | Adds Node.js engine requirement and updates @types/node to v24 |
| .github/workflows/*.yml | Updates CI workflows to use Node.js 24.x |
| tests/distributors/*.test.ts | Fixes TypeScript type issues with os.arch() mocking |
| .licenses/npm/*.dep.yml | Updates license information for dependency version changes |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
| jest.spyOn(os,'arch').mockReturnValue(distroArch); | ||
| jest | ||
| .spyOn(os,'arch') | ||
| .mockReturnValue(osArchasReturnType<typeofos.arch>); |
CopilotAIAug 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The mock is usingosArch but should be usingdistroArch to match the test parameter. This inconsistency could cause the test to not properly validate the architecture mapping.
Copilot uses AI. Check for mistakes.
aparnajyothi-y approved these changesAug 20, 2025
mahabaleshwars approved these changesAug 20, 2025
HarithaVattikuti approved these changesAug 20, 2025
0913e9a intoactions:main 364 checks passed
Uh oh!
There was an error while loading.Please reload this page.
mergifybot added a commit to ArcadeData/arcadedb that referenced this pull requestAug 24, 2025
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0.Release notes*Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).*> v5.0.0> ------>> What's Changed> -------------->> ### Breaking Changes>> * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888)>> Make sure your runner is updated to this version or newer to use this release. v2.327.1 [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)>> ### Dependency Upgrades>> * Upgrade Publish Immutable Action by [`@HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#798](https://redirect.github.com/actions/setup-java/pull/798)> * Upgrade eslint-plugin-jest from 27.9.0 to 28.11.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#730](https://redirect.github.com/actions/setup-java/pull/730)> * Upgrade undici from 5.28.5 to 5.29.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#833](https://redirect.github.com/actions/setup-java/pull/833)> * Upgrade form-data to bring in fix for critical vulnerability by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#887](https://redirect.github.com/actions/setup-java/pull/887)> * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#896](https://redirect.github.com/actions/setup-java/pull/896)>> ### Bug Fixes>> * Prevent default installation of JetBrains pre-releases by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-java#859](https://redirect.github.com/actions/setup-java/pull/859)> * Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failures by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848)>> New Contributors> ---------------->> * [`@gowridurgad`](https://github.com/gowridurgad) made their first contribution in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848)> * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888)>> **Full Changelog**: <actions/setup-java@v4...v5.0.0>Commits* [`dded088`](actions/setup-java@dded088) Bump actions/checkout from 4 to 5 ([#896](https://redirect.github.com/actions/setup-java/issues/896))* [`0913e9a`](actions/setup-java@0913e9a) Upgrade to node 24 ([#888](https://redirect.github.com/actions/setup-java/issues/888))* [`e9343db`](actions/setup-java@e9343db) Bumps form-data ([#887](https://redirect.github.com/actions/setup-java/issues/887))* [`ae2b61d`](actions/setup-java@ae2b61d) Bump undici from 5.28.5 to 5.29.0 ([#833](https://redirect.github.com/actions/setup-java/issues/833))* [`c190c18`](actions/setup-java@c190c18) Bump eslint-plugin-jest from 27.9.0 to 29.0.1 ([#730](https://redirect.github.com/actions/setup-java/issues/730))* [`67aec00`](actions/setup-java@67aec00) Fix: prevent default installation of JetBrains pre-releases ([#859](https://redirect.github.com/actions/setup-java/issues/859))* [`ebb356c`](actions/setup-java@ebb356c) Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failu...* [`f4f1212`](actions/setup-java@f4f1212) Update publish-immutable-actions.yml ([#798](https://redirect.github.com/actions/setup-java/issues/798))* See full diff in [compare view](actions/setup-java@c5195ef...dded088) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---Dependabot commands and options You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it- `@dependabot cancel merge` will cancel a previously requested merge and block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mergifybot added a commit to robfrank/linklift that referenced this pull requestSep 8, 2025
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.7.1 to 5.0.0.Release notes*Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).*> v5.0.0> ------>> What's Changed> -------------->> ### Breaking Changes>> * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888)>> Make sure your runner is updated to this version or newer to use this release. v2.327.1 [Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1)>> ### Dependency Upgrades>> * Upgrade Publish Immutable Action by [`@HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#798](https://redirect.github.com/actions/setup-java/pull/798)> * Upgrade eslint-plugin-jest from 27.9.0 to 28.11.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#730](https://redirect.github.com/actions/setup-java/pull/730)> * Upgrade undici from 5.28.5 to 5.29.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#833](https://redirect.github.com/actions/setup-java/pull/833)> * Upgrade form-data to bring in fix for critical vulnerability by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#887](https://redirect.github.com/actions/setup-java/pull/887)> * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-java#896](https://redirect.github.com/actions/setup-java/pull/896)>> ### Bug Fixes>> * Prevent default installation of JetBrains pre-releases by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-java#859](https://redirect.github.com/actions/setup-java/pull/859)> * Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failures by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848)>> New Contributors> ---------------->> * [`@gowridurgad`](https://github.com/gowridurgad) made their first contribution in [actions/setup-java#848](https://redirect.github.com/actions/setup-java/pull/848)> * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-java#888](https://redirect.github.com/actions/setup-java/pull/888)>> **Full Changelog**: <actions/setup-java@v4...v5.0.0>Commits* [`dded088`](actions/setup-java@dded088) Bump actions/checkout from 4 to 5 ([#896](https://redirect.github.com/actions/setup-java/issues/896))* [`0913e9a`](actions/setup-java@0913e9a) Upgrade to node 24 ([#888](https://redirect.github.com/actions/setup-java/issues/888))* [`e9343db`](actions/setup-java@e9343db) Bumps form-data ([#887](https://redirect.github.com/actions/setup-java/issues/887))* [`ae2b61d`](actions/setup-java@ae2b61d) Bump undici from 5.28.5 to 5.29.0 ([#833](https://redirect.github.com/actions/setup-java/issues/833))* [`c190c18`](actions/setup-java@c190c18) Bump eslint-plugin-jest from 27.9.0 to 29.0.1 ([#730](https://redirect.github.com/actions/setup-java/issues/730))* [`67aec00`](actions/setup-java@67aec00) Fix: prevent default installation of JetBrains pre-releases ([#859](https://redirect.github.com/actions/setup-java/issues/859))* [`ebb356c`](actions/setup-java@ebb356c) Improve Error Handling for Setup-Java Action to Help Debug Intermittent Failu...* [`f4f1212`](actions/setup-java@f4f1212) Update publish-immutable-actions.yml ([#798](https://redirect.github.com/actions/setup-java/issues/798))* See full diff in [compare view](actions/setup-java@c5195ef...dded088) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.[//]: # (dependabot-automerge-start)[//]: # (dependabot-automerge-end)---Dependabot commands and options You can trigger Dependabot actions by commenting on this PR:- `@dependabot rebase` will rebase this PR- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it- `@dependabot merge` will merge this PR after your CI passes on it- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it- `@dependabot cancel merge` will cancel a previously requested merge and block automerging- `@dependabot reopen` will reopen this PR if it is closed- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading action to node 24 since new runner version.
Description:
Describe your changes.
Related issue:
Add link to the related issue.
Check list: