- Notifications
You must be signed in to change notification settings - Fork588
Fix workflow example for downloading by artifact ID#402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes the workflow example to support downloading artifacts by defining and exposing the artifact ID as an output.
- Added a job-level output for the artifact ID in the upload job
- Renamed the upload step to "upload-step" and updated its reference in the subsequent step
- Improved readability with spacing and comments
Comments suppressed due to low confidence (1)
docs/MIGRATION.md:231
- The step id 'upload-step' is clear in this context; ensure that all related references remain consistent as per the updated output mapping.
id: upload-stepUh oh!
There was an error while loading.Please reload this page.
| paths-ignore: | ||
| - '**.md' | ||
| pull_request: | ||
| paths-ignore: | ||
| - '**.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since this is required CI, we can't skip it.
7745437 intomainUh oh!
There was an error while loading.Please reload this page.
artifact-idsinput #401@ramonpetgrave64 pointed out that the upload job was not defining any outputs, preventing this example from working:
#401 (comment)
I've updated the example to define that job output and make it clear that the upload step output is not being passed directly between jobs. I've also added some spacing for readability.