From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> To: Peter Smith <smithpb2250(at)gmail(dot)com> Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> Subject: Re: Conflict detection and logging in logical replication Date: 2024-08-26 09:52:01 Message-ID: CAA4eK1+HEKwG_UYt4Zvwh5o_HoCKCjEGesRjJX38xAH3OxuuYA@mail.gmail.com Views: Whole Thread |Raw Message |Download mbox |Resend email Thread: 2024-06-21 07:47:20 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-06-24 02:09:27 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-06-24 11:43:25 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-06-24 12:35:07 from Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> 2024-06-26 02:57:47 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-07-03 03:00:50 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-07-10 09:39:17 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-11 02:17:17 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-07-11 05:03:02 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-18 02:22:16 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-07-18 05:50:22 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-19 08:36:34 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-22 09:03:07 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-25 06:34:08 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-07-25 10:42:15 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-07-26 11:33:41 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-07-29 06:14:30 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-07-29 09:24:57 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-07-29 10:59:11 from Dilip Kumar <dilipbalaut(at)gmail(dot)com> 2024-07-29 12:14:48 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-07-30 08:19:33 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-07-30 08:41:40 from Dilip Kumar <dilipbalaut(at)gmail(dot)com> 2024-07-30 09:06:24 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-31 02:10:24 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-07-31 05:35:36 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-01 03:39:56 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-07-31 10:53:14 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-01 03:40:09 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-01 06:09:41 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-01 08:56:13 from "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> 2024-08-01 11:53:16 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-02 11:03:06 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>📎 2024-08-02 12:58:13 from Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> 2024-08-05 03:48:55 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-05 04:35:01 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-05 05:01:46 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-13 03:57:23 from Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> 2024-08-04 07:52:09 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-05 04:15:23 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-05 10:52:20 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-06 08:15:27 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-07 05:23:36 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-09 06:59:29 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-09 11:45:12 from Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> 2024-08-12 03:33:05 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-13 11:32:33 from Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> 2024-08-14 02:31:10 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-14 14:15:10 from Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> 2024-08-15 07:18:42 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-16 04:23:25 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-16 11:46:45 from Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> 2024-08-19 03:38:47 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-12 04:00:34 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-12 11:40:47 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-13 04:39:15 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-13 11:03:43 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>📎 2024-08-14 02:35:34 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-14 11:01:56 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>📎 2024-08-15 07:17:50 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-16 05:16:43 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-16 06:18:14 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-16 06:49:14 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-16 09:24:41 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-18 08:56:52 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-19 03:37:51 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-19 04:49:43 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-19 06:07:44 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-19 06:23:50 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-19 06:39:43 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-19 07:02:19 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-19 09:33:03 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-19 10:46:37 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>📎 2024-08-20 04:36:35 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-20 11:15:24 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-21 03:39:32 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-21 09:32:23 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-21 05:30:43 from "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> 2024-08-21 09:33:02 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-21 06:15:37 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-21 06:44:42 from Peter Smith <smithpb2250(at)gmail(dot)com> 2024-08-21 09:34:45 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-22 02:58:10 from Peter Smith <smithpb2250(at)gmail(dot)com>📎 2024-08-22 03:25:24 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-22 07:11:04 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-22 08:02:52 from Peter Smith <smithpb2250(at)gmail(dot)com> 2024-08-22 08:51:42 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-26 09:52:01 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-26 10:36:29 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-26 12:14:19 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-26 23:07:10 from Peter Smith <smithpb2250(at)gmail(dot)com> 2024-08-28 03:30:17 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-28 04:11:07 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-28 04:14:11 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>📎 2024-08-28 05:53:01 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-28 06:54:27 from Peter Smith <smithpb2250(at)gmail(dot)com> 2024-08-28 09:37:04 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-19 07:03:04 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-08-18 08:49:37 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-16 06:31:10 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-18 08:49:12 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-21 01:32:30 from "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> 2024-08-21 03:05:47 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-21 10:35:21 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-07 04:01:28 from "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>📎 2024-08-07 06:59:59 from "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> 2024-08-07 07:38:08 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-07 08:41:43 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-26 06:24:45 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-26 09:33:44 from Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> 2024-07-26 10:07:24 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-26 10:25:51 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-07-26 10:57:55 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-29 04:01:07 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-07-29 11:55:22 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-24 04:50:24 from Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> 2024-07-26 04:09:22 from shveta malik <shveta(dot)malik(at)gmail(dot)com> 2024-07-26 06:26:03 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-08-04 07:34:21 from "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> 2024-08-05 04:20:38 from Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> 2024-07-11 09:06:13 from shveta malik <shveta(dot)malik(at)gmail(dot)com> Lists: pgsql-hackers
On Thu, Aug 22, 2024 at 2:21 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote: > > On Thu, Aug 22, 2024 at 1:33 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote: > > > > Do you think the documentation for the 'column_value' parameter of the > > conflict logging should say that the displayed value might be > > truncated? > > > > I updated the patch to mention this and pushed it. >
Peter Smith mentioned to me off-list that the names of conflict types 'update_differ' and 'delete_differ' are not intuitive as compared to all other conflict types like insert_exists, update_missing, etc. The other alternative that comes to mind for those conflicts is to name them as 'update_origin_differ'/''delete_origin_differ'.
The description in docs for 'update_differ' is as follows: Updating a row that was previously modified by another origin. Note that this conflict can only be detected when track_commit_timestamp is enabled on the subscriber. Currently, the update is always applied regardless of the origin of the local row.
Does anyone else have any thoughts on the naming of these conflicts?
-- With Regards, Amit Kapila.