From: Alexander Lakhin <exclusion(at)gmail(dot)com> To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> Cc: Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, Tender Wang <tndrwang(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Michael Paquier <michael(at)paquier(dot)xyz> Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails Date: 2024-10-24 14:00:00 Message-ID: 461e9c26-2076-8224-e119-84998b6a784e@gmail.com Views: Whole Thread |Raw Message |Download mbox |Resend email Thread: 2023-07-05 21:30:28 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>📎 2023-07-31 12:57:53 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2023-08-03 06:55:03 from tender wang <tndrwang(at)gmail(dot)com> 2023-08-03 09:02:43 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2023-08-03 09:34:40 from tender wang <tndrwang(at)gmail(dot)com>📎 2023-08-04 09:04:29 from tender wang <tndrwang(at)gmail(dot)com> 2023-08-04 10:10:53 from tender wang <tndrwang(at)gmail(dot)com> 2023-08-07 11:15:54 from tender wang <tndrwang(at)gmail(dot)com> 2023-08-07 11:25:04 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2023-08-10 15:03:45 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> 2023-10-25 11:51:45 from tender wang <tndrwang(at)gmail(dot)com> 2023-10-25 12:12:53 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2023-10-27 09:05:49 from tender wang <tndrwang(at)gmail(dot)com>📎 2024-07-18 06:34:43 from Tender Wang <tndrwang(at)gmail(dot)com>📎 2024-07-19 13:18:28 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-07-22 05:52:19 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-07-26 06:36:16 from Junwang Zhao <zhjwpku(at)gmail(dot)com>📎 2024-07-26 06:56:51 from Junwang Zhao <zhjwpku(at)gmail(dot)com> 2024-07-26 08:36:08 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-07-26 09:08:34 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-07 22:50:10 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-08-08 02:16:40 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-08 14:25:35 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-20 01:51:16 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-20 02:25:13 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-08-20 02:45:47 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-21 22:00:46 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-08-22 03:19:23 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-22 07:07:26 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-22 18:41:50 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-08-23 02:44:19 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-08-20 08:26:51 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> 2024-08-21 03:09:27 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-09-02 21:01:47 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> 2024-09-03 02:16:44 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-09-03 09:26:37 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> 2024-09-03 09:55:12 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-09-04 22:57:28 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>📎 2024-09-25 12:42:40 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>📎 2024-09-25 14:14:07 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>📎 2024-09-26 08:48:35 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>📎 2024-10-18 14:50:59 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-10-21 08:30:45 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-10-21 21:52:18 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-10-22 02:56:34 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-10-22 14:54:45 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> 2024-10-22 14:23:12 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> 2024-10-22 14:32:33 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-10-23 08:01:54 from Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com> 2024-10-24 14:00:00 from Alexander Lakhin <exclusion(at)gmail(dot)com> 2024-10-24 15:27:31 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-10-25 06:51:28 from Tender Wang <tndrwang(at)gmail(dot)com>📎 2024-10-25 08:30:33 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-10-25 09:06:38 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-10-26 19:28:54 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-10-26 21:47:08 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-10-27 11:00:44 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-10-28 09:16:17 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>📎 2024-10-28 11:42:54 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-11-05 21:06:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> 2024-11-06 15:38:22 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-11-06 17:53:07 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-11-08 15:42:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> 2024-11-10 13:28:40 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-11-10 15:46:48 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> 2024-10-25 14:00:00 from Alexander Lakhin <exclusion(at)gmail(dot)com> 2024-10-25 15:14:37 from Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 2024-10-28 08:45:17 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-09-05 04:56:39 from Tender Wang <tndrwang(at)gmail(dot)com> 2024-07-23 02:15:47 from Tender Wang <tndrwang(at)gmail(dot)com> Lists: pgsql-hackers
Hello Alvaro,
22.10.2024 17:32, Alvaro Herrera wrote: > Yeah. I pushed these patches finally, thanks!
Please look at a new anomaly introduced with 53af9491a. When running the following script: CREATE TABLE t (a int, b int, PRIMARY KEY (a, b)); CREATE TABLE pt (a int, b int, FOREIGN KEY (a, b) REFERENCES t(a, b)) PARTITION BY LIST (a);
CREATE TABLE tp1 (x int, a int, b int); ALTER TABLE tp1 DROP COLUMN x;
ALTER TABLE pt ATTACH PARTITION tp1 FOR VALUES IN (1);
ALTER TABLE pt DETACH PARTITION tp1;
I get a memory access error detected by Valgrind: 2024-10-24 12:05:04.645 UTC [1079077] LOG: statement: ALTER TABLE pt DETACH PARTITION tp1; ==00:00:00:07.887 1079077== Invalid read of size 2 ==00:00:00:07.887 1079077== at 0x4A61DD: DetachPartitionFinalize (tablecmds.c:19545) ==00:00:00:07.887 1079077== by 0x4A5C11: ATExecDetachPartition (tablecmds.c:19386) ==00:00:00:07.887 1079077== by 0x48561E: ATExecCmd (tablecmds.c:5540) ==00:00:00:07.887 1079077== by 0x4845DE: ATRewriteCatalogs (tablecmds.c:5203) ==00:00:00:07.887 1079077== by 0x4838EC: ATController (tablecmds.c:4758) ==00:00:00:07.887 1079077== by 0x4834F1: AlterTable (tablecmds.c:4404) ==00:00:00:07.887 1079077== by 0x7D6D52: ProcessUtilitySlow (utility.c:1318) ==00:00:00:07.887 1079077== by 0x7D65F7: standard_ProcessUtility (utility.c:1067) ==00:00:00:07.887 1079077== by 0x7D54F7: ProcessUtility (utility.c:523) ==00:00:00:07.887 1079077== by 0x7D3D70: PortalRunUtility (pquery.c:1158) ==00:00:00:07.887 1079077== by 0x7D3FE7: PortalRunMulti (pquery.c:1316) ==00:00:00:07.887 1079077== by 0x7D3431: PortalRun (pquery.c:791)
Reproduced on REL_15_STABLE .. master.
Best regards, Alexander