Aklapper (Andre Klapper (WMF))Bugwrangler | Release Engineering | Developer AdvocacyAdministrator
Projects (40)
User Details
- User Since
- Sep 17 2014, 6:19 PM (555 w, 1 d)
- Roles
- Administrator
- Availability
- Available
- IRC Nick
- andre
- LDAP User
- Aklapper
- MediaWiki User
- AKlapper (WMF) [Global Accounts ]
Seemw:Bugwrangler for more information.
Member ofRelease-Engineering-Team. I am not a Product Manager.
Recent Activity
Today
Do you mean that the languages in the Language dropdown menu are not up-to-date, and that some languages are missing?
Hi, there is no such user. Is this abouthttps://gitlab.wikimedia.org/kiril ?
Also, can you pleaseconnect your wiki account to your Phabricator account so it is shown onhttps://phabricator.wikimedia.org/p/Kiril_kovachev/ ? Thanks!
Doesn't this already exist?:https://phabricator.wikimedia.org/p/Slack_connector_for_Editing_team_triage/
if you actually checked out the links I provided, there is no reason you wouldn't know about this issue.
Hi@Intodesa, thanks for taking the time to report this! Unfortunately this Wikimedia Phabricator task lacks some information.
Pleaseadd a more complete description to this task. That should be
- a clear and complete list of exact steps to reproduce the situation, step by step, so that nobody needs to guess or interpret how you performed each step,
- what happens after performing these steps to reproduce,
- what you expected to happen instead.
In seperate sections.
Next time if you think that there is an error, please use the bug report template.
Yesterday
@OWresch-WMF: Is a custom form still wanted? If not please set the task status todeclined. If yes please seeT392598#10794726. Thanks!
It'shttps://phabricator.wikimedia.org/maniphest/query/edit/ (probably for admins to show / edit "Global Saved Queries"?)
InT393587#10802879,@Justman10000 wrote:The question remains: who guarantees that I can submit patches faster than others?
InT393587#10802879,@Justman10000 wrote:How can I prove myself if I don't have any options available?
You repeatedly talked about "commit directly" here so I assume that you can provide an example when people "committed directly" (whatever that phrase means)?
Please link to one specific example or proof where someone committed directly a change for "requested permission changes for user groups or extension requests/configurations". One.
Wed, May 7
Could you simply answer my question and link to one specific example?
Why should I submit patches when others can commit directly?
Provide one specific example where someone "committed directly" instead of going via a patch. One. Thanks.
You have been told before first to write patches to "modify group permissions". You have not yet. Feel free to start contributing instead of asking for more permissions first. Thanks.
I guess we don't let random folks push random commits without review to potentially bring down Wikimedia websites. I hope that does not come as a surprise.
Welcome to the concept of code review.
InT393587#10801218,@Justman10000 wrote:Does everyone have access to that?
InT393587#10801076,@Justman10000 wrote:And without a chance I can't prove the opposite!
InT393587#10801047,@Justman10000 wrote:Implement changesdirectly!
Sure, please feel free to point to other meaningful technical contributions if there are no code contributions.
Is that why one don't give someone a chance?
A chance to do what exactly? Reviewing code changes? You can do that already. It requires no special rights.
Besides that, I do not know what makes you think that you needops as you have not yet answered that question.
I just don't want to look stupid when I want to do something, but I can't because no permission!
InT393587#10800392,@Justman10000 wrote:Please provide a link to non-trivial, merged code changes of yours.
I don't have one!
Again: What exactly makes you think that you "needops for optimal working"?
InT393587#10800240,@Justman10000 wrote:Which one should I follow?
InT393587#10800239,@Justman10000 wrote:But I needops for optimal working!
Also perhttps://wikitech.wikimedia.org/wiki/SRE/LDAP/Groups/Request_access this is the wrong form. Which docs are you following and why?
Perhttps://wikitech.wikimedia.org/wiki/SRE/LDAP/Groups,ops is for SRE staff only.
Also, looking athttps://gerrit.wikimedia.org/r/q/Justman10000 I see one typo fix so far? I'd say that much more technical experience is needed as a deployer.
Depends on what you want to do and why. There is a "I need access or permissions to..." box onhttps://phabricator.wikimedia.org.
@MBinder_WMF: Thank you, very appreciated. Yes, I should have explicitly mentioned that I was looking/hoping for your Agile expertise, sorry. :)
Tue, May 6
InT392005#10782282,@LMora-WMF wrote:
@Atieno: Assuming this task is about theNotifications (Echo) code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects or looking at workboards. Please set appropriate project tags when possible. Thanks!
@Atieno: Assuming this task is about theAbuseFilter code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects or looking at workboards. Please set appropriate project tags when possible. Thanks!
Please add code project tags.
People should add the Hackathon tag when they plan to work on a project at the Hackathon, not when they wish that someone else would (otherwise we could tag every open task).
Hi, please follow the relevant documentation and fill out the corresponding form.
Whatever<tabber> is and does, that is not a standard MediaWiki thing, so you need to contact urbanshade.org about their customizations.
Anyname in mind?
P75809 on top ofhttps://we.phorge.it/D25991 seems to work but I don't understand the full call stack. So not sure if that one check is enough.
Needs more testing:
| 1 | diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php |
|---|---|
| 2 | index 369419e0d3..414a7d74b3 100644 |
| 3 | --- a/src/__phutil_library_map__.php |
| 4 | +++ b/src/__phutil_library_map__.php |
| 5 | @@ -4506,6 +4506,7 @@ phutil_register_library_map(array( |
| 6 | 'PhabricatorProjectTriggerInvalidRule' => 'applications/project/trigger/PhabricatorProjectTriggerInvalidRule.php', |
| 7 | 'PhabricatorProjectTriggerListController' => 'applications/project/controller/trigger/PhabricatorProjectTriggerListController.php', |
| 8 | 'PhabricatorProjectTriggerManiphestOwnerRule' => 'applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerRule.php', |
| 9 | + 'PhabricatorProjectTriggerManiphestOwnerUnassignedRule' => 'applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerUnassignedRule.php', |
| 10 | 'PhabricatorProjectTriggerManiphestPriorityRule' => 'applications/project/trigger/PhabricatorProjectTriggerManiphestPriorityRule.php', |
| 11 | 'PhabricatorProjectTriggerManiphestStatusRule' => 'applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php', |
| 12 | 'PhabricatorProjectTriggerNameTransaction' => 'applications/project/xaction/trigger/PhabricatorProjectTriggerNameTransaction.php', |
| 13 | @@ -11165,6 +11166,7 @@ phutil_register_library_map(array( |
| 14 | 'PhabricatorProjectTriggerInvalidRule' => 'PhabricatorProjectTriggerRule', |
| 15 | 'PhabricatorProjectTriggerListController' => 'PhabricatorProjectTriggerController', |
| 16 | 'PhabricatorProjectTriggerManiphestOwnerRule' => 'PhabricatorProjectTriggerRule', |
| 17 | + 'PhabricatorProjectTriggerManiphestOwnerUnassignedRule' => 'PhabricatorProjectTriggerRule', |
| 18 | 'PhabricatorProjectTriggerManiphestPriorityRule' => 'PhabricatorProjectTriggerRule', |
| 19 | 'PhabricatorProjectTriggerManiphestStatusRule' => 'PhabricatorProjectTriggerRule', |
| 20 | 'PhabricatorProjectTriggerNameTransaction' => 'PhabricatorProjectTriggerTransactionType', |
| 21 | diff --git a/src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerRule.php b/src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerRule.php |
| 22 | index cc26ed7311..064e980e39 100644 |
| 23 | --- a/src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerRule.php |
| 24 | +++ b/src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerRule.php |
| 25 | @@ -1,6 +1,6 @@ |
| 26 | <?php |
| 27 | |
| 28 | -final class PhabricatorProjectTriggerManiphestOwnerRule |
| 29 | +class PhabricatorProjectTriggerManiphestOwnerRule |
| 30 | extends PhabricatorProjectTriggerRule { |
| 31 | |
| 32 | const TRIGGERTYPE = 'task.owner'; |
| 33 | @@ -13,7 +13,7 @@ final class PhabricatorProjectTriggerManiphestOwnerRule |
| 34 | return $this->getDatasource()->getWireTokens($this->getValue()); |
| 35 | } |
| 36 | |
| 37 | - private function convertTokenizerValueToOwner($value) { |
| 38 | + protected function convertTokenizerValueToOwner($value) { |
| 39 | $value = head($value); |
| 40 | if ($value === PhabricatorPeopleNoOwnerDatasource::FUNCTION_TOKEN) { |
| 41 | $value = null; |
| 42 | diff --git a/src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerUnassignedRule.php b/src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerUnassignedRule.php |
| 43 | new file mode 100644 |
| 44 | index 0000000000..8359d51606 |
| 45 | --- /dev/null |
| 46 | +++ b/src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerUnassignedRule.php |
| 47 | @@ -0,0 +1,25 @@ |
| 48 | +<?php |
| 49 | + |
| 50 | +final class PhabricatorProjectTriggerManiphestOwnerUnassignedRule |
| 51 | + extends PhabricatorProjectTriggerManiphestOwnerRule { |
| 52 | + |
| 53 | + const TRIGGERTYPE = 'task.owner.unassigned'; |
| 54 | + |
| 55 | + public function getSelectControlName() { |
| 56 | + return pht('Assign unowned task to'); |
| 57 | + } |
| 58 | + |
| 59 | + protected function newDropTransactions($object, $value) { |
| 60 | + if ($object->getOwnerPHID()) { // do nothing if task already has assignee |
| 61 | + return array(); |
| 62 | + } else { |
| 63 | + $value = $this->convertTokenizerValueToOwner($value); |
| 64 | + return array( |
| 65 | + $this->newTransaction() |
| 66 | + ->setTransactionType(ManiphestTaskOwnerTransaction::TRANSACTIONTYPE) |
| 67 | + ->setNewValue($value), |
| 68 | + ); |
| 69 | + } |
| 70 | + } |
| 71 | + |
| 72 | +} |
Step One: Enable preview while editing.
Where? How, by following which exact steps?
Also, please:
include links if applicable
I'd be interesting though what you'd like to see regarding "Work distribution by tags" and "Visualize some queries".
Not that I could quickly add such code at all but having specific use cases is always useful.
Yes but only by writing/adding more PHP code.
In the first step, entering the search term "chocolate" should match a sprint name which has "Chocolate cake", but no result is found
I vaguely remember something about search failing when it's the second token in a string but don't remember where. In any case, that would be a separate bug forPhabricator (Search).
Unassigning as account has no auth provider connected. Problem still exists though.
How can I choose which project to tag?
@CristianCantoro: Byrequesting a dedicated project tag if you want to use Wikimedia Phabricator for planning the development of wikidata-duplicate-authors. :)
@Jan.Kamenicek Ah. Increasing priority does not magically make bored developers appear (plus it does not need "WMF" programmers). Please seehttps://www.mediawiki.org/wiki/Bug_management/Development_prioritization - thanks.
Ah, makes sense (and I guess I could have known myself, sorry!).
@Sarai-WMF: Thanks for participating in the Hackathon! We hope you had a great time.
@HNordeenWMF: Thanks for participating in the Hackathon! We hope you had a great time.
@dcaro: Thanks for participating in the Hackathon! We hope you had a great time.
@Pintoch: Thanks for participating in the Hackathon! We hope you had a great time.
@Olea: Thanks for participating in the Hackathon! We hope you had a great time.
@REsquito-WMF: Thanks for participating in the Hackathon! We hope you had a great time.
@Arcstur: Thanks for participating in the Hackathon! We hope you had a great time.
@Harej: Thanks for participating in the Hackathon! We hope you had a great time.
@Harej: Thanks for participating in the Hackathon! We hope you had a great time.
@HCoplin-WMF: Thanks for participating in the Hackathon! We hope you had a great time.
@Acrion-dev: Thanks for participating in the Hackathon! We hope you had a great time.
@Esanders: Thanks for participating in the Hackathon! We hope you had a great time.
@Krabina: Thanks for participating in the Hackathon! We hope you had a great time.
@Acrion-dev: Thanks for participating in the Hackathon! We hope you had a great time.
@OTichonova: Thanks for participating in the Hackathon! We hope you had a great time.