On Fri, Jun 27, 2008 at 11:06 AM, <demon(a)svn.wikimedia.org> wrote:> Log Message:> -----------> Add no-ops for the (un)lock functions.>> Modified Paths:> --------------> trunk/phase3/includes/db/DatabaseMssql.php> trunk/phase3/includes/db/DatabaseOracle.php> trunk/phase3/includes/db/DatabaseSqlite.phpYou know, maybe it would be an interesting idea to actually use realpolymorphism in the Database class rather than making Database ==DatabaseMySQL and have everything else override that? How about theno-op lock() and unlock() go in Database, and get overridden inDatabaseMySQL (which is the only one where they're different)?