wasm wrapper: add DYNAMIC_EXECUTION=0 flag#984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

AlexXiong-dev wants to merge1 commit intozxing-cpp:master

base:master

Choose a base branch

Open

Conversation

Copy link

Contributor

To fix the CSP issue in discussions#977, need to add flag DYNAMIC_EXECUTION=0 when building the wasm binary.

wasm wrapper: add DYNAMIC_EXECUTION=0 flag

517c610

To fix CSP issue, need to add flag DYNAMIC_EXECUTION=0 during building the wasm binary.More details in discussionszxing-cpp#977

Copy link

ContributorAuthor

Please check if this impacts the current functions. If it does not, please review and merge it. Thank you.

Copy link

Collaborator

Looking at the documentation you provided, I have the following thoughts:

if that change strictly increases the usability, then we should surely apply it
since you seem to be able to run the code with that change, then none of the throwing functions are used
the document mentions a potential loss in performance, depending on how much this affects the library, this change would be unsuitable for the general use case
@Sec-ant what is your approach to this subject?

None yet