Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix SYMBOLOGY_IDENTIFIER Loss in QRCodeMultiReader to Ensure Data Integrity and Functional Consistency with QRCodeReader#1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
srowen merged 1 commit intozxing:masterfromxiebaiyuan:master
Aug 2, 2024

Conversation

@xiebaiyuan
Copy link
Contributor

@xiebaiyuanxiebaiyuan commentedAug 1, 2024•
edited
Loading

Background

The current use ofQRCodeMultiReader has an issue with the loss ofSYMBOLOGY_IDENTIFIER. This affects the ability to accurately determine if a QR code is GS1-compliant, as GS1-QR codes can be identified by theSYMBOLOGY_IDENTIFIER field being]Q3 (refer toGS1 Barcode Specifications).

Changes

Added handling logic forSYMBOLOGY_IDENTIFIER in theQRCodeMultiReader class, incorporating it into the decoding result metadata.

Benefits

  • Data Integrity: Ensures theSYMBOLOGY_IDENTIFIER information is preserved, improving the completeness of decoding results.
  • Compatibility: Enhances support for applications that requireSYMBOLOGY_IDENTIFIER information, such as ]Q3 for GS1-QR.
  • Functional Consistency: AlignsQRCodeMultiReader capabilities with those ofQRCodeReader.

Technical Details

  • Addedresult.putMetadata(ResultMetadataType.SYMBOLOGY_IDENTIFIER, "]Q" + decoderResult.getSymbologyModifier()); in thedecodeMultiple method.

Reference

@srowen
Copy link
Contributor

I think this is probably OK but can you explain it?

xiebaiyuan reacted with heart emoji

@xiebaiyuan
Copy link
ContributorAuthor

xiebaiyuan commentedAug 1, 2024•
edited
Loading

I think this is probably OK but can you explain it?

Thx~

In some scenarios, it is necessary to use this marker to determine that the QR code is also a GS1 code, i.e., ]Q3. QrCodeReader already supports this capability. In some cases, having multiple codes is also necessary, hence this PR.

@srowen
Copy link
Contributor

Right, can you explain the value here, any reference to specs or sources?
That would be good to include in the PR description and a comment

@xiebaiyuanxiebaiyuan changed the titleFix SYMBOLOGY_IDENTIFIER loss in QRCodeMultiReaderFix SYMBOLOGY_IDENTIFIER Loss in QRCodeMultiReader to Ensure Data Integrity and Functional Consistency with QRCodeReaderAug 2, 2024
@xiebaiyuan
Copy link
ContributorAuthor

Right, can you explain the value here, any reference to specs or sources? That would be good to include in the PR description and a comment

Thank you for your feedback. I have updated the PR description and added references to the relevant specifications and sources. Please review the latest PR description and comments to ensure they meet your requirements.

@srowensrowen added this to the3.5.4 milestoneAug 2, 2024
@srowensrowen merged commit8944e60 intozxing:masterAug 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@xiebaiyuanxiebaiyuan

Milestone

3.5.4

Development

Successfully merging this pull request may close these issues.

2 participants

@xiebaiyuan@srowen
[8]ページ先頭
©2009-2025 Movatter.jp