Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork391
hg: Display formatted user name.#874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Niloth-p wants to merge1 commit intozulip:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| def parse_user(user: str) -> str: | ||
| """Extract the name from user string, or fall back to email or raw string.""" | ||
| # Match: "Name <email@example.com>" | ||
| match = re.match(r"^(.*)<([^>]+)>$", user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Doesn't Python have anemailaddress module for parsing these correctly? There's no reason to write custom regexes to parse standard formats.
29e9d95 to6939913Compare12 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mercurial: Format the user name to hide the user's email in the summary line of the message.
Motivation: Updating example screenshots in integration docs.
Mercurial's
ctx.user()returns the username.The username can be set from these sources:
$HGUSER[ui] usernamein.hgrc.The username could be in any of the following formats, and may have extra spaces anywhere:
username <email>(the recommended format)username<email>I've added a
parse_userfunction which supports all the formats, and strips extra spaces.It could have been written in a couple of lines, but I've kept the function elaborate and used intermediate variables for readability.
How did you test this PR?
I did not.
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (seecommit discipline).
Completed manual review and testing of the following: