Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve codebase's message template#873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Niloth-p wants to merge2 commits intozulip:main
base:main
Choose a base branch
Loading
fromNiloth-p:templates-for-screenshots/codebase

Conversation

Niloth-p
Copy link
Contributor

Add backticks for branch names.
Motivation: Updating example screenshots in integration docs.


How did you test this PR?
I did not test the changes.


I added the automatic changes on linting and formatting (on editor save) as the first commit, so that the actual functional changes are identifiable clearly in a separate commit.

Would we prefer to:

  • Do this sort of formatting updates to all the files together? In that case, should I remove the changes in the first commit, and just add backticks to the templates in the format() calls?
  • Merge this and worry about the rest later?
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (seecommit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Niloth-p@zulipbot

[8]ページ先頭

©2009-2025 Movatter.jp